Issue 9163003: Fix GCC4.7 compilation warning introduced in r10400

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9163003: Fix GCC4.7 compilation warning introduced in r10400 (Closed)

Created:
8 years, 11 months ago by yurys

Modified:
8 years, 11 months ago

Reviewers:
Tobias Burnus, mnaganov (inactive), danno, pfeldman, loislo

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Fix GCC4.7 compilation warning introduced in r10400 Add some usages for string1 and string2 to avoid "assigned but not used" warning. Committed: http://code.google.com/p/v8/source/detail?r=10405

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	test/cctest/test-api.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Tobias Burnus

I cannot give an official approval, but it looks good to me and v8 successfully ...

8 years, 11 months ago (2012-01-16 10:39:53 UTC) #2

yurys

8 years, 11 months ago (2012-01-16 12:19:50 UTC) #4

On 2012/01/16 10:55:36, danno wrote:
> LGTM. I'll land it for you.

Thanks Daniel.

Expand Messages | Collapse Messages