Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 9160032: [Coverity] Pass AutocompleteMatch to predicate as const-ref (Closed)

Created:
8 years, 11 months ago by Tyler Breisacher (Chromium)
Modified:
8 years, 10 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, James Su
Visibility:
Public.

Description

[Coverity] Pass AutocompleteMatch to predicate as const-ref CID=100203 BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120725

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/autocomplete/shortcuts_provider.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Tyler Breisacher (Chromium)
8 years, 11 months ago (2012-01-24 19:18:12 UTC) #1
Tyler Breisacher (Chromium)
8 years, 10 months ago (2012-02-07 02:07:58 UTC) #2
Peter Kasting
LGTM
8 years, 10 months ago (2012-02-07 02:20:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/9160032/1
8 years, 10 months ago (2012-02-07 02:23:13 UTC) #4
commit-bot: I haz the power
8 years, 10 months ago (2012-02-07 05:44:21 UTC) #5
Change committed as 120725

Powered by Google App Engine
This is Rietveld 408576698