Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 9160018: Remove unnecessary IGNORE policy from Lithium operands. (Closed)

Created:
8 years, 11 months ago by fschneider
Modified:
8 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

Remove unnecessary IGNORE policy from Lithium operands. 1. This policy was only used for unused spill operands. I'm assigning an INVALID LOperand to those instead. As a result, we only need 3 bits to encode the policy and have one more available for virtual registers. 2. Furthermore, corrected the calculation of the maximal number of virtual registers and changed the upper limit for the size of the Hydrogen IR accordingly. 3. Doubled the maximal number of deoptimization entries to 8K. Committed: http://code.google.com/p/v8/source/detail?r=10481

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -20 lines) Patch
M src/deoptimizer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/lithium.h View 1 5 chunks +6 lines, -10 lines 0 comments Download
M src/lithium.cc View 1 2 chunks +2 lines, -3 lines 2 comments Download
M src/lithium-allocator.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
fschneider
8 years, 11 months ago (2012-01-24 01:49:22 UTC) #1
Kevin Millikin (Chromium)
LGTM. http://codereview.chromium.org/9160018/diff/4001/src/lithium.cc File src/lithium.cc (right): http://codereview.chromium.org/9160018/diff/4001/src/lithium.cc#newcode41 src/lithium.cc:41: break; You promised to write some dead code ...
8 years, 11 months ago (2012-01-24 02:06:56 UTC) #2
fschneider
8 years, 11 months ago (2012-01-24 02:13:51 UTC) #3
http://codereview.chromium.org/9160018/diff/4001/src/lithium.cc
File src/lithium.cc (right):

http://codereview.chromium.org/9160018/diff/4001/src/lithium.cc#newcode41
src/lithium.cc:41: break;
On 2012/01/24 02:06:56, Kevin Millikin wrote:
> You promised to write some dead code at lunch, and here it is.
> 
> Extra break.

Done :)

Powered by Google App Engine
This is Rietveld 408576698