Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 9160012: Change PluginWindowHandle to AcceleratedWidget in ui/gfx/gl (Closed)

Created:
8 years, 11 months ago by piman
Modified:
8 years, 10 months ago
CC:
chromium-reviews, dhollowa+watch_chromium.org, darin-cc_chromium.org, apatrick_chromium
Visibility:
Public.

Description

Change PluginWindowHandle to AcceleratedWidget in ui/gfx/gl BUG=104551 TEST=compile Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119990

Patch Set 1 : . #

Patch Set 2 : oops mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -136 lines) Patch
M gpu/demos/framework/window.h View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/demos/framework/window.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/demos/framework/window_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/demos/framework/window_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/demos/framework/window_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/khronos/EGL/eglplatform.h View 1 chunk +8 lines, -3 lines 0 comments Download
M third_party/khronos/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/compositor/compositor.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M ui/gfx/gl/gl_context_nsview.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/gl/gl_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gl/gl_surface_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gl/gl_surface_egl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/gl/gl_surface_egl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gl/gl_surface_glx.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/gl/gl_surface_glx.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gl/gl_surface_linux.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ui/gfx/gl/gl_surface_mac.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gl/gl_surface_nsview.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/gl/gl_surface_nsview.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gl/gl_surface_wgl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/gl/gl_surface_wgl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gl/gl_surface_win.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ui/gfx/native_widget_types.h View 2 chunks +7 lines, -6 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 10 chunks +3 lines, -78 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
piman
tony: OWNERS in webkit/gpu kbr: main review Note: this doesn't get rid of all the ...
8 years, 10 months ago (2012-01-31 00:37:36 UTC) #1
tony
You don't need my OK for webkit/gpu, there's a webkit/gpu/OWNERS with kbr in it.
8 years, 10 months ago (2012-01-31 00:45:24 UTC) #2
piman
On Mon, Jan 30, 2012 at 4:45 PM, <tony@chromium.org> wrote: > You don't need my ...
8 years, 10 months ago (2012-01-31 00:47:47 UTC) #3
Ken Russell (switch to Gerrit)
LGTM
8 years, 10 months ago (2012-01-31 20:06:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/9160012/15002
8 years, 10 months ago (2012-01-31 20:14:20 UTC) #5
commit-bot: I haz the power
Presubmit check for 9160012-15002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 10 months ago (2012-01-31 20:14:37 UTC) #6
piman
+ben for UI
8 years, 10 months ago (2012-01-31 20:21:11 UTC) #7
Ben Goodger (Google)
lgtm
8 years, 10 months ago (2012-01-31 20:27:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/9160012/15002
8 years, 10 months ago (2012-01-31 20:29:15 UTC) #9
commit-bot: I haz the power
8 years, 10 months ago (2012-02-01 00:07:23 UTC) #10
Change committed as 119990

Powered by Google App Engine
This is Rietveld 408576698