Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 9159058: Initialized variable w16_stopPos to 0. (Closed)

Created:
8 years, 10 months ago by asharif1
Modified:
8 years, 8 months ago
CC:
bjanakiraman1
Base URL:
http://git.chromium.org/external/webrtc/src.git@master
Visibility:
Public.

Description

Initialized variable w16_stopPos to 0. This suppresses gcc-4.6.0's warning: -Wmaybe-uninitialized. BUG=none TEST=trybot.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M modules/audio_coding/neteq/merge.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
asharif1
PTAL. Can you also fix in upstream webrtc? Thanks,
8 years, 10 months ago (2012-01-31 03:36:33 UTC) #1
hlundin-webrtc
On 2012/01/31 03:36:33, asharif1 wrote: > PTAL. Can you also fix in upstream webrtc? > ...
8 years, 10 months ago (2012-01-31 12:57:11 UTC) #2
kjellander_webrtc
LGTM. I spent some time on trying to get this warning enabled for us, but ...
8 years, 10 months ago (2012-01-31 14:44:46 UTC) #3
asharif1
On 2012/01/31 14:44:46, kjellander wrote: > LGTM. > I spent some time on trying to ...
8 years, 10 months ago (2012-01-31 19:09:13 UTC) #4
M-A Ruel
8 years, 10 months ago (2012-02-09 19:11:33 UTC) #5
BTW;

You used the wrong rietveld instance for a webrtc change and this project is not
supported by the commit queue.

Powered by Google App Engine
This is Rietveld 408576698