Issue 9159037: Use CORS for fetching NaCl resources from extensions.

Issue 9159037: Use CORS for fetching NaCl resources from extensions. (Closed)

Created:
8 years, 10 months ago by jvoung - send to chromium...

Modified:
8 years, 10 months ago

Reviewers:
Jorge Lucangeli Obes (Google), sehr (please use chromium), bbudge

CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use CORS for fetching NaCl resources from extensions. Undoes some changes done to allow PNaCl to read its own files from an extension: http://codereview.chromium.org/8974020/ R=bbudge@chromium.org,sehr@google.com,jorgelo@google.com BUG=108131 TEST= extension_mime_handler test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119953

Patch Set 2 : update a comment #

Patch Set 3 : redundant todo... thanks elijah =) #

Total comments: 2

Patch Set 4 : add webkit bug# #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -80 lines)			Patch
M	chrome/test/nacl_test_injection/buildbot_nacl_integration.py	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/browser_nacl_file_rpc_server.cc	View	1 2 3	1 chunk	+1 line, -3 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/file_downloader.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/file_downloader.cc	View	1 2 3	4 chunks	+9 lines, -12 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/json_manifest.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/json_manifest.cc	View		7 chunks	+5 lines, -15 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/manifest.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/plugin.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/plugin.cc	View		6 chunks	+2 lines, -9 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc	View		6 chunks	+6 lines, -18 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/pnacl_resources.cc	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/service_runtime.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	ppapi/native_client/tests/ppapi_browser/extension_mime_handler/manifest.json	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

sehr (please use chromium)

One nit. Otherwise LGTM. https://chromiumcodereview.appspot.com/9159037/diff/4002/ppapi/native_client/src/shared/ppapi_proxy/browser_nacl_file_rpc_server.cc File ppapi/native_client/src/shared/ppapi_proxy/browser_nacl_file_rpc_server.cc (right): https://chromiumcodereview.appspot.com/9159037/diff/4002/ppapi/native_client/src/shared/ppapi_proxy/browser_nacl_file_rpc_server.cc#newcode41 ppapi/native_client/src/shared/ppapi_proxy/browser_nacl_file_rpc_server.cc:41: remote_callback); nit: please join lines.

8 years, 10 months ago (2012-01-30 23:16:23 UTC) #3

jvoung - send to chromium...

Thanks for the reviews! Also added the webkit bug number for "data:" schemes that Adam ...

8 years, 10 months ago (2012-01-30 23:35:11 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@google.com/9159037/7001

8 years, 10 months ago (2012-01-31 18:15:43 UTC) #6

Change committed as 119953

Expand Messages | Collapse Messages