Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sql/diagnostic_error_delegate.h

Issue 9159020: Create a class to represent a DOM Storage Database. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Tidy up. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sql/statement.h » ('j') | webkit/dom_storage/dom_storage_database.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sql/diagnostic_error_delegate.h
diff --git a/sql/diagnostic_error_delegate.h b/sql/diagnostic_error_delegate.h
index 6a09fc0ef4c05da883c9b7b5a6e3ce6688be2eae..dd57f100214d919f47cd59a86a23ed92f9fc3fb5 100644
--- a/sql/diagnostic_error_delegate.h
+++ b/sql/diagnostic_error_delegate.h
@@ -28,9 +28,9 @@ class DiagnosticErrorDelegate : public ErrorDelegate {
virtual int OnError(int error, Connection* connection,
Statement* stmt) {
- NOTREACHED() << "sqlite error " << error
- << ", errno " << connection->GetLastErrno()
- << ": " << connection->GetErrorMessage();
+ LOG(ERROR) << "sqlite error " << error
michaeln 2012/02/08 06:11:33 Switching to LOG(ERROR) here sgtm.
+ << ", errno " << connection->GetLastErrno()
+ << ": " << connection->GetErrorMessage();
RecordErrorInHistogram(error);
return error;
}
« no previous file with comments | « no previous file | sql/statement.h » ('j') | webkit/dom_storage/dom_storage_database.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698