Create a class to represent a DOM Storage Database.

sql/diagnostic_error_delegate.h

Index: sql/diagnostic_error_delegate.h
diff --git a/sql/diagnostic_error_delegate.h b/sql/diagnostic_error_delegate.h
index 6a09fc0ef4c05da883c9b7b5a6e3ce6688be2eae..1b6c8059621bc8d2f4eeaebb23a391cd782005a4 100644
--- a/sql/diagnostic_error_delegate.h
+++ b/sql/diagnostic_error_delegate.h
@@ -28,10 +28,10 @@ class DiagnosticErrorDelegate : public ErrorDelegate {
 
   virtual int OnError(int error, Connection* connection,
                       Statement* stmt) {
-    NOTREACHED() << "sqlite error " << error
+/*    NOTREACHED() << "sqlite error " << error
                  << ", errno " << connection->GetLastErrno()
                  << ": " << connection->GetErrorMessage();
-    RecordErrorInHistogram(error);
+*/    RecordErrorInHistogram(error);

[benm (inactive), 2012/02/06 18:19:41]

d'oh, didn't mean to leave this in. This NOTREACHED() causes us to fail in the
test that tries to open the directory as that case actually causes the
Connection::Open call to die. As I understsand it, this only fails in debug
builds?

Should this NOTREACHED() be demoted to a LOG(ERROR), or should I remove the test
for opening a directory? Or is there a way to tell unit tests to ignore/not
crash on NOTREACHED() ? Any other ways around this?

     return error;
   }