Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: webkit/dom_storage/dom_storage_database.h

Issue 9159020: Create a class to represent a DOM Storage Database. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Disable test that uses the webcore localstorage file pending the test data getting checked in. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/dom_storage/dom_storage_database.h
diff --git a/webkit/dom_storage/dom_storage_database.h b/webkit/dom_storage/dom_storage_database.h
new file mode 100644
index 0000000000000000000000000000000000000000..75878b69c70f8a6c34b867231923faabd19ebe92
--- /dev/null
+++ b/webkit/dom_storage/dom_storage_database.h
@@ -0,0 +1,91 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef WEBKIT_DOM_STORAGE_DOM_STORAGE_DATABASE_H_
+#define WEBKIT_DOM_STORAGE_DOM_STORAGE_DATABASE_H_
+
+#include <map>
+
+#include "base/file_path.h"
+#include "base/gtest_prod_util.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/nullable_string16.h"
+#include "base/string16.h"
+#include "sql/connection.h"
+
+namespace dom_storage {
+
+// Represents a SQLite based backing for DOM storage data. This
+// class is designed to be used on a single thread.
+class DomStorageDatabase {
+ public:
+ explicit DomStorageDatabase(const FilePath& file_path);
+ ~DomStorageDatabase();
+
+ typedef std::map<string16, NullableString16> ValuesMap;
+
+ // Reads all the key, value pairs stored in the database and returns
+ // them. |result| is assumed to be empty and any duplicate keys will
+ // be overwritten. If the database exists on disk then it will be
+ // opened. If it does not exist then it will not be created and
+ // |result| will be unmodified.
+ void ReadAllValues(ValuesMap* result);
+
+ // Updates the backing database. Will remove all keys before updating
+ // the database if |clear_all_first| is set. Then all entries in
+ // |changes| will be examined - keys mapped to a null NullableString16
+ // will be removed and all others will be inserted/updated as appropriate.
+ bool CommitChanges(bool clear_all_first, const ValuesMap& changes);
+
+ private:
+ FRIEND_TEST_ALL_PREFIXES(DomStorageDatabaseTest, SimpleOpenAndClose);
+ FRIEND_TEST_ALL_PREFIXES(DomStorageDatabaseTest, TestLazyOpenIsLazy);
+ FRIEND_TEST_ALL_PREFIXES(DomStorageDatabaseTest,
+ TestUpgradesV1TableToV2);
+ FRIEND_TEST_ALL_PREFIXES(DomStorageDatabaseTest, TestFailedUpgrade);
+ FRIEND_TEST_ALL_PREFIXES(DomStorageDatabaseTest, TestIsOpen);
+ FRIEND_TEST_ALL_PREFIXES(DomStorageDatabaseTest, SimpleRead);
+ FRIEND_TEST_ALL_PREFIXES(DomStorageDatabaseTest, SimpleWrite);
+ FRIEND_TEST_ALL_PREFIXES(DomStorageDatabaseTest, WriteWithClear);
+ FRIEND_TEST_ALL_PREFIXES(DomStorageDatabaseTest, UpgradeFromV1ToV2NoData);
+ FRIEND_TEST_ALL_PREFIXES(DomStorageDatabaseTest,
+ UpgradeFromV1ToV2WithData);
+ FRIEND_TEST_ALL_PREFIXES(DomStorageDatabaseTest,
+ TestOpenCloseDataPreserved);
+ FRIEND_TEST_ALL_PREFIXES(DomStorageDatabaseTest, TestSimpleRemoveOneValue);
+ FRIEND_TEST_ALL_PREFIXES(DomStorageDatabaseTest,
+ TestCanOpenAndReadWebCoreDatabase);
+
+ // Open the database at file_path_ if it exists already and creates it if
+ // |create_if_needed| is true.
+ // Ensures we are at the correct database version and creates or updates
+ // tables as necessary. Returns false on failure.
+ bool LazyOpen(bool create_if_needed);
+
+ // Creates the ItemTable at the current version of the database. Used
+ // when creating the table from scratch.
+ bool CreateTable();
+
+ // Creates the database table at V2. Used when upgrading the database
+ // table to V2.
+ bool CreateTableV2();
+
+ // Version 1 -> 2 migrates the value column in the ItemTable from a TEXT
+ // to a BLOB. Exisitng data is preserved on success. Returns false if the
+ // upgrade failed. If true is returned, the database is guaranteed to be at
+ // version 2 (either it already was, or the upgrade from version 1 was
+ // successful).
+ bool UpgradeVersion1To2IfNeeded();
+
+ void Close();
+ bool IsOpen() const { return db_.get() ? db_->is_open() : false; }
+
+ // Path to the database on disk.
+ FilePath file_path_;
+ scoped_ptr<sql::Connection> db_;
+};
+
+} // namespace dom_storage
+
+#endif // WEBKIT_DOM_STORAGE_DOM_STORAGE_DATABASE_H_

Powered by Google App Engine
This is Rietveld 408576698