Create a class to represent a DOM Storage Database.

sql/diagnostic_error_delegate.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SQL_DIAGNOSTIC_ERROR_DELEGATE_H_
 #define SQL_DIAGNOSTIC_ERROR_DELEGATE_H_
 #pragma once
 
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
@@ skipping 10 matching lines @@
 // need to be singletons that is why they are always static at the function
 // scope, but we cannot use the Singleton class because they are not default
 // constructible. The template parameter makes the compiler to create unique
 // classes that don't share the same static variable.
 template <class UniqueT>
 class DiagnosticErrorDelegate : public ErrorDelegate {
  public:
 
   virtual int OnError(int error, Connection* connection,
                       Statement* stmt) {
-    NOTREACHED() << "sqlite error " << error
+/*    NOTREACHED() << "sqlite error " << error
                  << ", errno " << connection->GetLastErrno()
                  << ": " << connection->GetErrorMessage();
-    RecordErrorInHistogram(error);
+*/    RecordErrorInHistogram(error);

[benm (inactive), 2012/02/06 18:19:41]

d'oh, didn't mean to leave this in. This NOTREACHED() causes us to fail in the
test that tries to open the directory as that case actually causes the
Connection::Open call to die. As I understsand it, this only fails in debug
builds?

Should this NOTREACHED() be demoted to a LOG(ERROR), or should I remove the test
for opening a directory? Or is there a way to tell unit tests to ignore/not
crash on NOTREACHED() ? Any other ways around this?

     return error;
   }
 
  private:
   static void RecordErrorInHistogram(int error) {
     // Trim off the extended error codes.
     error &= 0xff;
 
     // The histogram values from sqlite result codes go currently from 1 to
     // 26 currently but 50 gives them room to grow.
     UMA_HISTOGRAM_ENUMERATION(UniqueT::name(), error, 50);
   }
 };
 
 }  // namespace sql
 
 #endif  // SQL_DIAGNOSTIC_ERROR_DELEGATE_H_