Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Side by Side Diff: webkit/dom_storage/dom_storage_database_unittest.cc

Issue 9159020: Create a class to represent a DOM Storage Database. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: DomStorageDatabase for backing local storage to disk. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "webkit/dom_storage/dom_storage_database.h"
6
7 #include "base/file_path.h"
8 #include "base/path_service.h"
9 #include "base/scoped_temp_dir.h"
10 #include "base/utf_string_conversions.h"
11 #include "sql/statement.h"
12 #include "testing/gtest/include/gtest/gtest.h"
13
14 namespace dom_storage {
15
16 class DomStorageDatabaseTest : public testing::Test {
17 protected:
18 virtual void SetUp() {
19 ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
20 file_name_ = temp_dir_.path().AppendASCII("TestDomStorageDatabase.db");
21 }
22
23 void CreateV1Table(sql::Connection* db) {
24 ASSERT_FALSE(db->is_open());
25 ASSERT_TRUE(db->Open(file_name_));
26 ASSERT_TRUE(db->Execute("DROP TABLE IF EXISTS ItemTable"));
27 ASSERT_TRUE(db->Execute(
28 "CREATE TABLE IF NOT EXISTS ItemTable ("
29 "key TEXT UNIQUE ON CONFLICT REPLACE, "
30 "value TEXT NOT NULL ON CONFLICT FAIL)"));
31 }
32
33 void InsertDataV1(sql::Connection* db,
34 const string16& key,
35 const string16& value) {
36 sql::Statement stmt(db->GetCachedStatement(SQL_FROM_HERE,
37 "INSERT INTO ItemTable VALUES (?,?)"));
38 stmt.BindString16(0, key);
39 stmt.BindString16(1, value);
40 ASSERT_TRUE(stmt.is_valid());
41 stmt.Run();
42 }
43
44 void InsertDataV2(sql::Connection* db,
45 const string16& key,
46 const string16& value) {
47 sql::Statement stmt(db->GetCachedStatement(SQL_FROM_HERE,
48 "INSERT INTO ItemTable VALUES (?,?)"));
49 stmt.BindString16(0, key);
50 stmt.BindBlob(1, value.data(), value.length() * sizeof(char16));
51 ASSERT_TRUE(stmt.is_valid());
52 stmt.Run();
53 }
54
55 DomStorageDatabase::ValuesMap ReadAllRows(sql::Connection* db) {
56 DomStorageDatabase::ValuesMap values;
57 sql::Statement stmt(db->GetCachedStatement(SQL_FROM_HERE,
58 "SELECT * from ItemTable"));
59 EXPECT_TRUE(stmt.is_valid());
60 while (stmt.Step()) {
61 string16 key = stmt.ColumnString16(0);
62 string16 value;
63 stmt.ColumnBlobAsString16(1, &value);
64 values[key] = value;
65 }
66 return values;
67 }
68
69 void CheckValuesMatch(sql::Connection* db,
70 const DomStorageDatabase::ValuesMap& expected) {
71 const DomStorageDatabase::ValuesMap values_read = ReadAllRows(db);
72 EXPECT_EQ(expected.size(), values_read.size());
73
74 DomStorageDatabase::ValuesMap::const_iterator it = values_read.begin();
75 for (; it != values_read.end(); ++it) {
76 string16 key = it->first;
77 string16 value = it->second;
78 EXPECT_EQ(expected.find(key)->second, value);
79 }
80 }
81
82 ScopedTempDir temp_dir_;
83 FilePath file_name_;
84 };
85
86 TEST_F(DomStorageDatabaseTest, SimpleOpenAndClose) {
87 DomStorageDatabase db(file_name_);
88 ASSERT_TRUE(db.LazyOpen());
89 EXPECT_TRUE(db.db_->DoesTableExist("ItemTable"));
90 // Ensure that we've got the colums we expect.
91 EXPECT_TRUE(db.db_->DoesColumnExist("ItemTable", "key"));
92 EXPECT_TRUE(db.db_->DoesColumnExist("ItemTable", "value"));
93 {
94 sql::Statement stmt(db.db_->GetCachedStatement(SQL_FROM_HERE,
95 "SELECT * from ItemTable LIMIT 1"));
96 EXPECT_EQ(sql::COLUMN_TYPE_TEXT, stmt.DeclaredColumnType(0));
97 EXPECT_EQ(sql::COLUMN_TYPE_BLOB, stmt.DeclaredColumnType(1));
98 }
99 db.Close();
100 EXPECT_FALSE(db.IsOpen());
101 }
102
103 TEST_F(DomStorageDatabaseTest, TestUpgradesV1TableToV2) {
104 DomStorageDatabase db(file_name_);
105 db.db_.reset(new sql::Connection());
106 CreateV1Table(db.db_.get());
107 db.Close();
108
109 db.LazyOpen();
110 sql::Statement stmt(db.db_->GetCachedStatement(SQL_FROM_HERE,
111 "SELECT * from ItemTable LIMIT 1"));
112 EXPECT_EQ(sql::COLUMN_TYPE_TEXT, stmt.DeclaredColumnType(0));
113 EXPECT_EQ(sql::COLUMN_TYPE_BLOB, stmt.DeclaredColumnType(1));
114 }
115
116 TEST_F(DomStorageDatabaseTest, TestIsOpen) {
117 DomStorageDatabase db(file_name_);
118 EXPECT_FALSE(db.IsOpen());
119 ASSERT_TRUE(db.LazyOpen());
120 EXPECT_TRUE(db.IsOpen());
121 db.Close();
122 EXPECT_FALSE(db.IsOpen());
123 }
124
125 TEST_F(DomStorageDatabaseTest, SimpleRead) {
126 DomStorageDatabase db(file_name_);
127 db.LazyOpen();
128
129 const string16 kCannedKey = ASCIIToUTF16("name");
130 const string16 kCannedValue = ASCIIToUTF16("Joe Bloggs");
131
132 InsertDataV2(db.db_.get(), kCannedKey, kCannedValue);
133 DomStorageDatabase::ValuesMap values;
134 db.ReadAllValues(&values);
135
136 EXPECT_EQ(1u, values.size());
137 EXPECT_NE(values.end(), values.find(kCannedKey));
138 EXPECT_EQ(kCannedValue, values[kCannedKey]);
139 }
140
141 TEST_F(DomStorageDatabaseTest, SimpleWrite) {
142 DomStorageDatabase db(file_name_);
143
144 DomStorageDatabase::ValuesMap storage;
145 string16 kCannedKeys[] = {
146 ASCIIToUTF16("test"),
147 ASCIIToUTF16("company"),
148 ASCIIToUTF16("date")
149 };
150 string16 kCannedValues[] = {
151 ASCIIToUTF16("123"),
152 ASCIIToUTF16("Google"),
153 ASCIIToUTF16("18-01-2012")
154 };
155 for (int i = 0; i < 3; i++) {
156 storage[kCannedKeys[i]] = kCannedValues[i];
157 }
158
159 ASSERT_TRUE(db.WriteValues(storage));
160
161 CheckValuesMatch(db.db_.get(), storage);
162 }
163
164 TEST_F(DomStorageDatabaseTest, UpgradeFromV1ToV2NoData) {
165 DomStorageDatabase db(file_name_);
166 db.db_.reset(new sql::Connection());
167 CreateV1Table(db.db_.get());
168
169 // The database has V1 structure, try to update it to V2.
170 sql::Statement stmt(db.db_->GetCachedStatement(SQL_FROM_HERE,
171 "SELECT value from ItemTable LIMIT 1"));
172 ASSERT_EQ(sql::COLUMN_TYPE_TEXT, stmt.DeclaredColumnType(0));
173
174 ASSERT_TRUE(db.UpgradeVersion1To2IfNeeded());
175
176 // Verify the db now has V2 structure.
177 sql::Statement stmt2(db.db_->GetCachedStatement(SQL_FROM_HERE,
178 "SELECT value from ItemTable LIMIT 1"));
179 EXPECT_EQ(sql::COLUMN_TYPE_BLOB, stmt2.DeclaredColumnType(0));
180 }
181
182 TEST_F(DomStorageDatabaseTest, UpgradeFromV1ToV2WithData) {
183 const string16 kCannedKey = ASCIIToUTF16("foo");
184 const string16 kCannedValue = ASCIIToUTF16("bar");
185 DomStorageDatabase::ValuesMap expected;
186 expected[kCannedKey] = kCannedValue;
187
188 {
189 DomStorageDatabase db(file_name_);
190 db.db_.reset(new sql::Connection());
191 CreateV1Table(db.db_.get());
192
193 // The database has V1 structure, try to update it to V2.
194 sql::Statement stmt(db.db_->GetCachedStatement(SQL_FROM_HERE,
195 "SELECT value from ItemTable LIMIT 1"));
196 ASSERT_EQ(sql::COLUMN_TYPE_TEXT, stmt.DeclaredColumnType(0));
197
198 InsertDataV1(db.db_.get(), kCannedKey, kCannedValue);
199
200 ASSERT_TRUE(db.UpgradeVersion1To2IfNeeded());
201
202 // Verify the db now has V2 structure.
203 sql::Statement stmt2(db.db_->GetCachedStatement(SQL_FROM_HERE,
204 "SELECT value from ItemTable LIMIT 1"));
205 EXPECT_EQ(sql::COLUMN_TYPE_BLOB, stmt2.DeclaredColumnType(0));
206
207 CheckValuesMatch(db.db_.get(), expected);
208 }
209
210 // Now open the db again and check that the data is consistent.
211 {
212 DomStorageDatabase db(file_name_);
213 ASSERT_TRUE(db.LazyOpen());
214 CheckValuesMatch(db.db_.get(), expected);
215 }
216 }
217
218 TEST_F(DomStorageDatabaseTest, TestOpenCloseDataPreserved) {
219 DomStorageDatabase db(file_name_);
220
221 ASSERT_TRUE(db.LazyOpen());
222
223 const string16 kCannedKey = ASCIIToUTF16("test");
224 const string16 kCannedValue = ASCIIToUTF16("data");
225 InsertDataV2(db.db_.get(), kCannedKey, kCannedValue);
226 db.Close();
227
228 ASSERT_TRUE(db.LazyOpen());
229 DomStorageDatabase::ValuesMap expected;
230 expected[kCannedKey] = kCannedValue;
231 CheckValuesMatch(db.db_.get(), expected);
232 }
233
234 TEST_F(DomStorageDatabaseTest, TestSimpleRemoveOneValue) {
235 DomStorageDatabase db(file_name_);
236
237 ASSERT_TRUE(db.LazyOpen());
238 const string16 kCannedKey = ASCIIToUTF16("test");
239 const string16 kCannedValue = ASCIIToUTF16("data");
240 InsertDataV2(db.db_.get(), kCannedKey, kCannedValue);
241
242 DomStorageDatabase::ValuesMap expected;
243 expected[kCannedKey] = kCannedValue;
244 CheckValuesMatch(db.db_.get(), expected);
245
246 DomStorageDatabase::ValuesSet values;
247 values.insert(kCannedKey);
248
249 db.RemoveValues(values);
250
251 expected.clear();
252 CheckValuesMatch(db.db_.get(), expected);
253 }
254
255 TEST_F(DomStorageDatabaseTest, TestCanOpenAndReadWebCoreDatabase) {
256 {
257 FilePath webcore_database;
258 PathService::Get(base::DIR_SOURCE_ROOT, &webcore_database);
259 webcore_database = webcore_database.AppendASCII("webkit");
260 webcore_database = webcore_database.AppendASCII("data");
261 webcore_database = webcore_database.AppendASCII("dom_storage");
262 webcore_database =
263 webcore_database.AppendASCII("webcore_test_database.localstorage");
264
265 DomStorageDatabase db(webcore_database);
266
267 DomStorageDatabase::ValuesMap values;
268 db.ReadAllValues(&values);
269 EXPECT_EQ(2u, values.size());
270
271 DomStorageDatabase::ValuesMap::const_iterator it =
272 values.find(ASCIIToUTF16("value"));
273 EXPECT_NE(values.end(), it);
274 EXPECT_EQ(ASCIIToUTF16("I am in local storage!"), it->second);
275
276 it = values.find(ASCIIToUTF16("timestamp"));
277 EXPECT_NE(values.end(), it);
278 EXPECT_EQ(ASCIIToUTF16("1326738338841"), it->second);
279
280 it = values.find(ASCIIToUTF16("not_there"));
281 EXPECT_EQ(values.end(), it);
282 }
283 }
284
285 } // namespace dom_storage
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698