Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: webkit/dom_storage/dom_storage_database_unittest.cc

Issue 9159020: Create a class to represent a DOM Storage Database. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Add DOM Storage database class. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "webkit/dom_storage/dom_storage_database.h"
6
7 #include "base/file_path.h"
8 #include "base/path_service.h"
9 #include "base/scoped_temp_dir.h"
10 #include "base/utf_string_conversions.h"
11 #include "sql/statement.h"
12 #include "testing/gtest/include/gtest/gtest.h"
13
14 namespace dom_storage {
15
16 class DomStorageDatabaseTest : public testing::Test {
17 protected:
18 virtual void SetUp() {
19 ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
20 file_name_ = temp_dir_.path().AppendASCII("TestDomStorageDatabase.db");
21 }
22
23 void CreateV1Table(sql::Connection* db) {
24 ASSERT_TRUE(db->Execute("DROP TABLE IF EXISTS ItemTable"));
25 ASSERT_TRUE(db->Execute(
26 "CREATE TABLE IF NOT EXISTS ItemTable ("
27 "key TEXT UNIQUE ON CONFLICT REPLACE, "
28 "value TEXT NOT NULL ON CONFLICT FAIL)"));
29 }
30
31 void InsertDataV1(sql::Connection* db,
32 const string16& key,
33 const string16& value) {
34 sql::Statement stmt(db->GetCachedStatement(SQL_FROM_HERE,
35 "INSERT INTO ItemTable VALUES (?,?)"));
36 stmt.BindString16(0, key);
37 stmt.BindString16(1, value);
38 ASSERT_TRUE(stmt.is_valid());
39 stmt.Run();
40 }
41
42 void InsertDataV2(sql::Connection* db,
43 const string16& key,
44 const string16& value) {
45 sql::Statement stmt(db->GetCachedStatement(SQL_FROM_HERE,
46 "INSERT INTO ItemTable VALUES (?,?)"));
47 stmt.BindString16(0, key);
48 stmt.BindBlob(1, value.c_str(), -1);
49 ASSERT_TRUE(stmt.is_valid());
50 stmt.Run();
51 }
52
53 DomStorageDatabase::ValuesMap ReadAllRows(sql::Connection* db) {
54 DomStorageDatabase::ValuesMap values;
55 sql::Statement stmt(db->GetCachedStatement(SQL_FROM_HERE,
56 "SELECT * from ItemTable"));
57 EXPECT_TRUE(stmt.is_valid());
58 while (stmt.Step()) {
59 string16 key = stmt.ColumnString16(0);
60 string16 value(reinterpret_cast<const char16*>(stmt.ColumnBlob(1)));
61 values[key] = value;
62 }
63 return values;
64 }
65
66 void CheckValuesMatch(sql::Connection* db,
67 const DomStorageDatabase::ValuesMap& expected) {
68 const DomStorageDatabase::ValuesMap values_read = ReadAllRows(db);
69 EXPECT_EQ(expected.size(), values_read.size());
70
71 DomStorageDatabase::ValuesMap::const_iterator it = values_read.begin();
72 for (; it != values_read.end(); ++it) {
73 string16 key = it->first;
74 string16 value = it->second;
75 EXPECT_EQ(expected.find(key)->second, value);
76 }
77 }
78
79 ScopedTempDir temp_dir_;
80 FilePath file_name_;
81 };
82
83 TEST_F(DomStorageDatabaseTest, SimpleOpenInitAndClose) {
84 DomStorageDatabase db(file_name_);
85 ASSERT_TRUE(db.Open());
86 ASSERT_TRUE(db.Init());
87 EXPECT_TRUE(db.db_->DoesTableExist("ItemTable"));
88 // Ensure that we've got the colums we expect.
89 EXPECT_TRUE(db.db_->DoesColumnExist("ItemTable", "key"));
90 EXPECT_TRUE(db.db_->DoesColumnExist("ItemTable", "value"));
91 {
92 sql::Statement stmt(db.db_->GetCachedStatement(SQL_FROM_HERE,
93 "SELECT * from ItemTable LIMIT 1"));
94 EXPECT_EQ(sql::COLUMN_TYPE_TEXT, stmt.DeclaredColumnType(0));
95 EXPECT_EQ(sql::COLUMN_TYPE_BLOB, stmt.DeclaredColumnType(1));
96 }
97 db.Close();
98 EXPECT_FALSE(db.IsOpen());
99 }
100
101 TEST_F(DomStorageDatabaseTest, TestInitUpgradesV1TableToV2) {
102 DomStorageDatabase db(file_name_);
103 ASSERT_TRUE(db.Open());
104 CreateV1Table(db.db_.get());
105 db.Close();
106
107 ASSERT_TRUE(db.Open());
108 ASSERT_TRUE(db.Init());
109 sql::Statement stmt(db.db_->GetCachedStatement(SQL_FROM_HERE,
110 "SELECT * from ItemTable LIMIT 1"));
111 EXPECT_EQ(sql::COLUMN_TYPE_TEXT, stmt.DeclaredColumnType(0));
112 EXPECT_EQ(sql::COLUMN_TYPE_BLOB, stmt.DeclaredColumnType(1));
113 }
114
115 TEST_F(DomStorageDatabaseTest, TestIsOpen) {
116 DomStorageDatabase db(file_name_);
117 EXPECT_FALSE(db.IsOpen());
118 ASSERT_TRUE(db.Open());
119 EXPECT_TRUE(db.IsOpen());
120 db.Close();
121 EXPECT_FALSE(db.IsOpen());
122 }
123
124 TEST_F(DomStorageDatabaseTest, SimpleRead) {
125 DomStorageDatabase db(file_name_);
126 ASSERT_TRUE(db.Open());
127 ASSERT_TRUE(db.Init());
128
129 const string16 kCannedKey = ASCIIToUTF16("name");
130 const string16 kCannedValue = ASCIIToUTF16("Joe Bloggs");
131
132 InsertDataV2(db.db_.get(), kCannedKey, kCannedValue);
133 DomStorageDatabase::ValuesMap values = db.ReadAllValues();
134
135 EXPECT_EQ(1u, values.size());
136 EXPECT_NE(values.end(), values.find(kCannedKey));
137 EXPECT_EQ(kCannedValue, values[kCannedKey]);
138 }
139
140 TEST_F(DomStorageDatabaseTest, SimpleWrite) {
141 DomStorageDatabase db(file_name_);
142 ASSERT_TRUE(db.Open());
143 ASSERT_TRUE(db.Init());
144
145 DomStorageDatabase::ValuesMap storage;
146 string16 kCannedKeys[] = {
147 ASCIIToUTF16("test"),
148 ASCIIToUTF16("company"),
149 ASCIIToUTF16("date")
150 };
151 string16 kCannedValues[] = {
152 ASCIIToUTF16("123"),
153 ASCIIToUTF16("Google"),
154 ASCIIToUTF16("18-01-2012")
155 };
156 for (int i = 0; i < 3; i++) {
157 storage[kCannedKeys[i]] = kCannedValues[i];
158 }
159
160 ASSERT_TRUE(db.WriteValues(storage));
161
162 CheckValuesMatch(db.db_.get(), storage);
163 }
164
165 TEST_F(DomStorageDatabaseTest, UpgradeFromV1ToV2NoData) {
166 DomStorageDatabase db(file_name_);
167 ASSERT_TRUE(db.Open());
168 CreateV1Table(db.db_.get());
169
170 // The database has V1 structure, try to update it to V2.
171 sql::Statement stmt(db.db_->GetCachedStatement(SQL_FROM_HERE,
172 "SELECT value from ItemTable LIMIT 1"));
173 ASSERT_EQ(sql::COLUMN_TYPE_TEXT, stmt.DeclaredColumnType(0));
174
175 ASSERT_TRUE(db.UpgradeVersion1To2IfNeeded());
176
177 // Verify the db now has V2 structure.
178 sql::Statement stmt2(db.db_->GetCachedStatement(SQL_FROM_HERE,
179 "SELECT value from ItemTable LIMIT 1"));
180 EXPECT_EQ(sql::COLUMN_TYPE_BLOB, stmt2.DeclaredColumnType(0));
181 }
182
183 TEST_F(DomStorageDatabaseTest, UpgradeFromV1ToV2WithData) {
184 const string16 kCannedKey = ASCIIToUTF16("foo");
185 const string16 kCannedValue = ASCIIToUTF16("bar");
186 DomStorageDatabase::ValuesMap expected;
187 expected[kCannedKey] = kCannedValue;
188
189 {
190 DomStorageDatabase db(file_name_);
191 ASSERT_TRUE(db.Open());
192 CreateV1Table(db.db_.get());
193
194 // The database has V1 structure, try to update it to V2.
195 sql::Statement stmt(db.db_->GetCachedStatement(SQL_FROM_HERE,
196 "SELECT value from ItemTable LIMIT 1"));
197 ASSERT_EQ(sql::COLUMN_TYPE_TEXT, stmt.DeclaredColumnType(0));
198
199 InsertDataV1(db.db_.get(), kCannedKey, kCannedValue);
200
201 ASSERT_TRUE(db.UpgradeVersion1To2IfNeeded());
202
203 // Verify the db now has V2 structure.
204 sql::Statement stmt2(db.db_->GetCachedStatement(SQL_FROM_HERE,
205 "SELECT value from ItemTable LIMIT 1"));
206 EXPECT_EQ(sql::COLUMN_TYPE_BLOB, stmt2.DeclaredColumnType(0));
207
208 CheckValuesMatch(db.db_.get(), expected);
209 }
210
211 // Now open the db again and check that the data is consistent.
212 {
213 DomStorageDatabase db(file_name_);
214 ASSERT_TRUE(db.Open());
215 ASSERT_TRUE(db.Init());
216 CheckValuesMatch(db.db_.get(), expected);
217 }
218 }
219
220 TEST_F(DomStorageDatabaseTest, TestOpenCloseDataPreserved) {
221 DomStorageDatabase db(file_name_);
222 ASSERT_TRUE(db.Open());
223 ASSERT_TRUE(db.Init());
224
225 const string16 kCannedKey = ASCIIToUTF16("test");
226 const string16 kCannedValue = ASCIIToUTF16("data");
227 InsertDataV2(db.db_.get(), kCannedKey, kCannedValue);
228 db.Close();
229
230 db.Open();
231 DomStorageDatabase::ValuesMap expected;
232 expected[kCannedKey] = kCannedValue;
233 CheckValuesMatch(db.db_.get(), expected);
234 }
235
236 TEST_F(DomStorageDatabaseTest, TestSimpleRemoveOneValue) {
237 DomStorageDatabase db(file_name_);
238 ASSERT_TRUE(db.Open());
239 ASSERT_TRUE(db.Init());
240
241 const string16 kCannedKey = ASCIIToUTF16("test");
242 const string16 kCannedValue = ASCIIToUTF16("data");
243 InsertDataV2(db.db_.get(), kCannedKey, kCannedValue);
244
245 DomStorageDatabase::ValuesMap expected;
246 expected[kCannedKey] = kCannedValue;
247 CheckValuesMatch(db.db_.get(), expected);
248
249 DomStorageDatabase::ValuesSet values;
250 values.insert(kCannedKey);
251
252 db.RemoveValues(values);
253
254 expected.clear();
255 CheckValuesMatch(db.db_.get(), expected);
256 }
257
258 TEST_F(DomStorageDatabaseTest, TestCanOpenAndReadWebCoreDatabase) {
259 {
260 FilePath webcore_database;
261 PathService::Get(base::DIR_SOURCE_ROOT, &webcore_database);
262 webcore_database = webcore_database.AppendASCII("webkit");
263 webcore_database = webcore_database.AppendASCII("data");
264 webcore_database = webcore_database.AppendASCII("dom_storage");
265 webcore_database =
266 webcore_database.AppendASCII("webcore_test_database.localstorage");
267 DomStorageDatabase db(webcore_database);
268 ASSERT_TRUE(db.Open());
269 ASSERT_TRUE(db.Init());
270
271 DomStorageDatabase::ValuesMap values = db.ReadAllValues();
272 EXPECT_EQ(2u, values.size());
273
274 DomStorageDatabase::ValuesMap::const_iterator it =
275 values.find(ASCIIToUTF16("value"));
276 EXPECT_NE(values.end(), it);
277 EXPECT_EQ(ASCIIToUTF16("I am in local storage!"), it->second);
278
279 it = values.find(ASCIIToUTF16("timestamp"));
280 EXPECT_NE(values.end(), it);
281 EXPECT_EQ(ASCIIToUTF16("1326738338841"), it->second);
282
283 it = values.find(ASCIIToUTF16("not_there"));
284 EXPECT_EQ(values.end(), it);
285 }
286 }
287
288 } // namespace dom_storage
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698