Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Side by Side Diff: webkit/dom_storage/local_storage_database_unittest.cc

Issue 9159020: Create a class to represent a DOM Storage Database. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "webkit/dom_storage/local_storage_database.h"
6
7 #include "base/file_path.h"
8 #include "base/scoped_temp_dir.h"
9 #include "base/utf_string_conversions.h"
10 #include "sql/statement.h"
11 #include "testing/gtest/include/gtest/gtest.h"
12
13 namespace dom_storage {
14
15 class LocalStorageDatabaseTest : public testing::Test {
16 protected:
17 virtual void SetUp() {
18 ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
19 file_name_ = temp_dir_.path().AppendASCII("TestLocalStorageDatabase.db");
20 }
21
22 void CreateV1Table(sql::Connection* db) {
23 ASSERT_TRUE(db->Execute("DROP TABLE IF EXISTS ItemTable"));
24 ASSERT_TRUE(db->Execute(
25 "CREATE TABLE IF NOT EXISTS ItemTable ("
26 "key TEXT UNIQUE ON CONFLICT REPLACE, "
27 "value TEXT NOT NULL ON CONFLICT FAIL)"));
28 }
29
30 void InsertDataV1(sql::Connection* db,
31 const string16& key,
32 const string16& value) {
33 sql::Statement stmt(db->GetCachedStatement(SQL_FROM_HERE,
34 "INSERT INTO ItemTable VALUES (?,?)"));
35 stmt.BindString16(0, key);
36 stmt.BindString16(1, value);
37 ASSERT_TRUE(stmt.is_valid());
38 stmt.Run();
39 }
40
41 void InsertDataV2(sql::Connection* db,
42 const string16& key,
43 const string16& value) {
44 sql::Statement stmt(db->GetCachedStatement(SQL_FROM_HERE,
45 "INSERT INTO ItemTable VALUES (?,?)"));
46 stmt.BindString16(0, key);
47 stmt.BindBlob(1, UTF16ToUTF8(value).c_str(), value.size());
48 ASSERT_TRUE(stmt.is_valid());
49 stmt.Run();
50 }
51
52 std::map<string16, string16> ReadAllRows(sql::Connection* db) {
53 std::map<string16, string16> values;
54 sql::Statement stmt(db->GetCachedStatement(SQL_FROM_HERE,
55 "SELECT * from ItemTable"));
56 EXPECT_TRUE(stmt.is_valid());
57 while (stmt.Step()) {
58 string16 key = stmt.ColumnString16(0);
59
60 std::string result;
61 stmt.ColumnBlobAsString(1, &result);
62 string16 value = UTF8ToUTF16(result);
63 values[key] = value;
64 }
65 return values;
66 }
67
68 void CheckValuesMatch(sql::Connection* db,
69 const std::map<string16, string16>& expected) {
70 const std::map<string16, string16> values_read = ReadAllRows(db);
71 EXPECT_EQ(expected.size(), values_read.size());
72
73 std::map<string16, string16>::const_iterator it = values_read.begin();
74 for (; it != values_read.end(); ++it) {
75 string16 key = it->first;
76 string16 value = it->second;
77 EXPECT_EQ(expected.find(key)->second, value);
78 }
79 }
80
81 ScopedTempDir temp_dir_;
82 FilePath file_name_;
83 };
84
85 TEST_F(LocalStorageDatabaseTest, SimpleOpenInitAndClose) {
86 LocalStorageDatabase db(file_name_);
87 ASSERT_TRUE(db.Open());
88 ASSERT_TRUE(db.Init());
89 EXPECT_EQ(2, db.GetVersionNumber());
90 EXPECT_TRUE(db.db_->DoesTableExist("ItemTable"));
91 // Ensure that we've got the colums we expect.
92 EXPECT_TRUE(db.db_->DoesColumnExist("ItemTable", "key"));
93 EXPECT_TRUE(db.db_->DoesColumnExist("ItemTable", "value"));
94 {
95 sql::Statement stmt(db.db_->GetCachedStatement(SQL_FROM_HERE,
96 "SELECT * from ItemTable LIMIT 1"));
97 EXPECT_EQ(sql::COLUMN_TYPE_TEXT, stmt.DeclaredColumnType(0));
98 EXPECT_EQ(sql::COLUMN_TYPE_BLOB, stmt.DeclaredColumnType(1));
99 }
100 db.Close();
101 EXPECT_FALSE(db.IsOpen());
102 }
103
104 TEST_F(LocalStorageDatabaseTest, TestInitUpgradesV1TableToV2) {
105 LocalStorageDatabase db(file_name_);
106 ASSERT_TRUE(db.Open());
107 CreateV1Table(db.db_.get());
108 db.Close();
109
110 ASSERT_TRUE(db.Open());
111 EXPECT_EQ(1, db.GetVersionNumber());
112 ASSERT_TRUE(db.Init());
113 EXPECT_EQ(2, db.GetVersionNumber());
114 sql::Statement stmt(db.db_->GetCachedStatement(SQL_FROM_HERE,
115 "SELECT * from ItemTable LIMIT 1"));
116 EXPECT_EQ(sql::COLUMN_TYPE_TEXT, stmt.DeclaredColumnType(0));
117 EXPECT_EQ(sql::COLUMN_TYPE_BLOB, stmt.DeclaredColumnType(1));
118 }
119
120 TEST_F(LocalStorageDatabaseTest, TestIsOpen) {
121 LocalStorageDatabase db(file_name_);
122 EXPECT_FALSE(db.IsOpen());
123 ASSERT_TRUE(db.Open());
124 EXPECT_TRUE(db.IsOpen());
125 db.Close();
126 EXPECT_FALSE(db.IsOpen());
127 }
128
129 TEST_F(LocalStorageDatabaseTest, SimpleRead) {
130 LocalStorageDatabase db(file_name_);
131 ASSERT_TRUE(db.Open());
132 ASSERT_TRUE(db.Init());
133
134 const string16 kCannedKey = ASCIIToUTF16("name");
135 const string16 kCannedValue = ASCIIToUTF16("Joe Bloggs");
136
137 InsertDataV2(db.db_.get(), kCannedKey, kCannedValue);
138 std::map<string16, string16> values = db.ReadAllValues();
139
140 EXPECT_EQ(1u, values.size());
141 EXPECT_NE(values.end(), values.find(kCannedKey));
142 EXPECT_EQ(kCannedValue, values[kCannedKey]);
143 }
144
145 TEST_F(LocalStorageDatabaseTest, SimpleWrite) {
146 LocalStorageDatabase db(file_name_);
147 ASSERT_TRUE(db.Open());
148 ASSERT_TRUE(db.Init());
149
150 std::map<string16, string16> storage;
151 string16 kCannedKeys[] = {
152 ASCIIToUTF16("test"),
153 ASCIIToUTF16("company"),
154 ASCIIToUTF16("date")
155 };
156 string16 kCannedValues[] = {
157 ASCIIToUTF16("123"),
158 ASCIIToUTF16("Google"),
159 ASCIIToUTF16("18-01-2012")
160 };
161 for (int i = 0; i < 3; i++) {
162 storage[kCannedKeys[i]] = kCannedValues[i];
163 }
164
165 ASSERT_TRUE(db.WriteAllValues(storage));
166
167 CheckValuesMatch(db.db_.get(), storage);
168 }
169
170 TEST_F(LocalStorageDatabaseTest, UpgradeFromV1ToV2NoData) {
171 LocalStorageDatabase db(file_name_);
172 ASSERT_TRUE(db.Open());
173 CreateV1Table(db.db_.get());
174
175 // The database has V1 structure, try to update it to V2.
176 sql::Statement stmt(db.db_->GetCachedStatement(SQL_FROM_HERE,
177 "SELECT value from ItemTable LIMIT 1"));
178 ASSERT_EQ(sql::COLUMN_TYPE_TEXT, stmt.DeclaredColumnType(0));
179
180 ASSERT_TRUE(db.UpgradeVersion1To2IfNeeded());
181
182 // Verify the db now has V2 structure.
183 sql::Statement stmt2(db.db_->GetCachedStatement(SQL_FROM_HERE,
184 "SELECT value from ItemTable LIMIT 1"));
185 EXPECT_EQ(sql::COLUMN_TYPE_BLOB, stmt2.DeclaredColumnType(0));
186 }
187
188 TEST_F(LocalStorageDatabaseTest, UpgradeFromV1ToV2WithData) {
189 LocalStorageDatabase db(file_name_);
190 ASSERT_TRUE(db.Open());
191 CreateV1Table(db.db_.get());
192
193 // The database has V1 structure, try to update it to V2.
194 sql::Statement stmt(db.db_->GetCachedStatement(SQL_FROM_HERE,
195 "SELECT value from ItemTable LIMIT 1"));
196 ASSERT_EQ(sql::COLUMN_TYPE_TEXT, stmt.DeclaredColumnType(0));
197
198 const string16 kCannedKey = ASCIIToUTF16("foo");
199 const string16 kCannedValue = ASCIIToUTF16("bar");
200 InsertDataV1(db.db_.get(), kCannedKey, kCannedValue);
201
202 ASSERT_TRUE(db.UpgradeVersion1To2IfNeeded());
203
204 // Verify the db now has V2 structure.
205 sql::Statement stmt2(db.db_->GetCachedStatement(SQL_FROM_HERE,
206 "SELECT value from ItemTable LIMIT 1"));
207 EXPECT_EQ(sql::COLUMN_TYPE_BLOB, stmt2.DeclaredColumnType(0));
208
209 std::map<string16, string16> expected;
210 expected[kCannedKey] = kCannedValue;
211 CheckValuesMatch(db.db_.get(), expected);
212 }
213
214 TEST_F(LocalStorageDatabaseTest, TestOpenCloseDataPreserved) {
215 LocalStorageDatabase db(file_name_);
216 ASSERT_TRUE(db.Open());
217 ASSERT_TRUE(db.Init());
218
219 const string16 kCannedKey = ASCIIToUTF16("test");
220 const string16 kCannedValue = ASCIIToUTF16("data");
221 InsertDataV2(db.db_.get(), kCannedKey, kCannedValue);
222 db.Close();
223
224 db.Open();
225 std::map<string16, string16> expected;
226 expected[kCannedKey] = kCannedValue;
227 CheckValuesMatch(db.db_.get(), expected);
228 }
229
230 } // namespace dom_storage
OLDNEW
« webkit/dom_storage/local_storage_database.cc ('K') | « webkit/dom_storage/local_storage_database.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698