Issue 9158035: Roll DEPS for Breakpad r897:r902. Mostly changes being upstreamed from CrOS's branch. Cleanup som...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9158035: Roll DEPS for Breakpad r897:r902. Mostly changes being upstreamed from CrOS's branch. Cleanup som... (Closed)

Created:
8 years, 11 months ago by Lei Zhang

Modified:
8 years, 11 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Roll DEPS for Breakpad r897:r902. Mostly changes being upstreamed from CrOS's branch. Cleanup some whitespaces while we're at it. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117602

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -3 lines)			Patch
M	DEPS	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	breakpad/breakpad.gyp	View	1	3 chunks	+24 lines, -0 lines	0 comments	Download
M	build/common.gypi	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM http://codereview.chromium.org/9158035/diff/1/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/9158035/diff/1/build/common.gypi#newcode35 build/common.gypi:35: Totally unrelated, but OK.

8 years, 11 months ago (2012-01-11 01:52:08 UTC) #2

Ben Chan

On 2012/01/11 01:45:38, Lei Zhang wrote: From r897:902, the following files/unit tests are added. The ...

8 years, 11 months ago (2012-01-11 01:54:45 UTC) #3

Lei Zhang

8 years, 11 months ago (2012-01-11 22:47:07 UTC) #5

On 2012/01/11 04:36:35, Lei Zhang wrote:
> Sure, I added the new tests in patch set 2.

If there's no objections to patch set 2, I'll commit beforethe end of day.

Expand Messages | Collapse Messages