Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 9158026: Fix bug 104170: [Mac OS] Best-fit-window-zoom doesn't work anymore (Closed)

Created:
8 years, 11 months ago by jianli
Modified:
8 years, 11 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Fix bug 104170: [Mac OS] Best-fit-window-zoom doesn't work anymore BUG=104170 TEST=Manual test by following repro steps in the bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117260

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/browser/tab_contents/tab_contents_view_mac.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jianli
8 years, 11 months ago (2012-01-10 22:23:31 UTC) #1
Avi (use Gerrit)
LGTM; how did this stop working?
8 years, 11 months ago (2012-01-11 03:18:11 UTC) #2
jianli
I did not realized that it was used in such case. On Tue, Jan 10, ...
8 years, 11 months ago (2012-01-11 06:49:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/9158026/1
8 years, 11 months ago (2012-01-11 06:56:35 UTC) #4
commit-bot: I haz the power
Failed to apply the patch.
8 years, 11 months ago (2012-01-11 08:21:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/9158026/1
8 years, 11 months ago (2012-01-11 18:21:29 UTC) #6
commit-bot: I haz the power
Change committed as 117260
8 years, 11 months ago (2012-01-11 19:37:36 UTC) #7
Avi (use Gerrit)
I'm super-sorry to have to say this, but this can't be the correct approach. There ...
8 years, 11 months ago (2012-01-13 21:24:33 UTC) #8
Avi (use Gerrit)
8 years, 11 months ago (2012-01-13 21:32:44 UTC) #9
Actually, I see how to fix this in a relatively simple way. Will send review.

Powered by Google App Engine
This is Rietveld 408576698