Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 9158025: Ignore the following http server properties in prefs file (Closed)

Created:
8 years, 11 months ago by ramant (doing other things)
Modified:
8 years, 11 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Ignore the following http server properties in prefs file if they are corrupted. - Spdy Settings, Alternate protocol R=wtc BUG=109789 TEST=unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117264

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 4

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -15 lines) Patch
M chrome/browser/net/http_server_properties_manager.h View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/net/http_server_properties_manager.cc View 1 2 3 4 11 chunks +17 lines, -10 lines 0 comments Download
M chrome/browser/net/http_server_properties_manager_unittest.cc View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
ramant (doing other things)
Hi Wan-Teh, Small change to ignore corrupted prefs file. thanks, raman
8 years, 11 months ago (2012-01-10 23:40:26 UTC) #1
wtc
LGTM. Should we remove the corrupted http server properties when we detect them?
8 years, 11 months ago (2012-01-11 01:23:34 UTC) #2
ramant (doing other things)
Hi Wan-Teh, Made a small change to update the prefs with what we have read ...
8 years, 11 months ago (2012-01-11 02:30:45 UTC) #3
wtc
Patch Set 2 LGTM. http://codereview.chromium.org/9158025/diff/3002/chrome/browser/net/http_server_properties_manager.cc File chrome/browser/net/http_server_properties_manager.cc (right): http://codereview.chromium.org/9158025/diff/3002/chrome/browser/net/http_server_properties_manager.cc#newcode385 chrome/browser/net/http_server_properties_manager.cc:385: ScheduleUpdatePrefsOnIO(); Is it possible to ...
8 years, 11 months ago (2012-01-11 02:47:41 UTC) #4
ramant (doing other things)
thanks very much Wan-Teh for your comments. Could you look at the latest changes one ...
8 years, 11 months ago (2012-01-11 03:22:23 UTC) #5
wtc
Patch Set 4 LGTM. http://codereview.chromium.org/9158025/diff/7003/chrome/browser/net/http_server_properties_manager.cc File chrome/browser/net/http_server_properties_manager.cc (right): http://codereview.chromium.org/9158025/diff/7003/chrome/browser/net/http_server_properties_manager.cc#newcode240 chrome/browser/net/http_server_properties_manager.cc:240: bool deleted_corrupted_prefs = false; This ...
8 years, 11 months ago (2012-01-11 03:26:40 UTC) #6
ramant (doing other things)
http://codereview.chromium.org/9158025/diff/7003/chrome/browser/net/http_server_properties_manager.cc File chrome/browser/net/http_server_properties_manager.cc (right): http://codereview.chromium.org/9158025/diff/7003/chrome/browser/net/http_server_properties_manager.cc#newcode240 chrome/browser/net/http_server_properties_manager.cc:240: bool deleted_corrupted_prefs = false; On 2012/01/11 03:26:41, wtc wrote: ...
8 years, 11 months ago (2012-01-11 03:30:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/9158025/6005
8 years, 11 months ago (2012-01-11 06:18:26 UTC) #8
commit-bot: I haz the power
Try job failure for 9158025-6005 (retry) on mac_rel for step "ui_tests". It's a second try, ...
8 years, 11 months ago (2012-01-11 08:51:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/9158025/6005
8 years, 11 months ago (2012-01-11 18:22:24 UTC) #10
commit-bot: I haz the power
8 years, 11 months ago (2012-01-11 19:57:50 UTC) #11
Change committed as 117264

Powered by Google App Engine
This is Rietveld 408576698