Synchronize access to TestAutomationResourceMessageFilter's requests_ map. This fixes a race cond...

Synchronize access to TestAutomationResourceMessageFilter's requests_ map. This fixes a race condition in Chrome Frame's net tests that could cause URLRequestJobs to be created and destroyed on different threads. This in turn leaks PowerObservers from SystemMonitor's observer list, resulting in an observer list full of dangling pointers. In debug mode this may eventually dcheck if heap addresses are reused.

BUG=109733
TEST=chrome_frame_net_tests.exe does not DCHECK.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117263

[grt (UTC plus 2), 2012-01-10 19:56:44]

LGTM following our discussion.  please add a comment explaining that the last
ref to a job must be released in the thread on which the job was created, and
that this code satisfies that requirement.

http://codereview.chromium.org/9158012/diff/1/chrome_frame/test/net/test_auto...
File chrome_frame/test/net/test_automation_resource_message_filter.cc (right):

http://codereview.chromium.org/9158012/diff/1/chrome_frame/test/net/test_auto...
chrome_frame/test/net/test_automation_resource_message_filter.cc:1: // Copyright
(c) 2011 The Chromium Authors. All rights reserved.
2012

http://codereview.chromium.org/9158012/diff/1/chrome_frame/test/net/test_auto...
File chrome_frame/test/net/test_automation_resource_message_filter.h (right):

http://codereview.chromium.org/9158012/diff/1/chrome_frame/test/net/test_auto...
chrome_frame/test/net/test_automation_resource_message_filter.h:1: // Copyright
(c) 2009 The Chromium Authors. All rights reserved.
2012

[robertshield, 2012-01-10 20:19:27]

Thanks! Detailed comment added for posterity.

http://codereview.chromium.org/9158012/diff/1/chrome_frame/test/net/test_auto...
File chrome_frame/test/net/test_automation_resource_message_filter.cc (right):

http://codereview.chromium.org/9158012/diff/1/chrome_frame/test/net/test_auto...
chrome_frame/test/net/test_automation_resource_message_filter.cc:1: // Copyright
(c) 2011 The Chromium Authors. All rights reserved.
On 2012/01/10 19:56:44, grt wrote:
> 2012

AAAGHH! I'm going on leave until December when it's usually safe to change code
again.

http://codereview.chromium.org/9158012/diff/1/chrome_frame/test/net/test_auto...
File chrome_frame/test/net/test_automation_resource_message_filter.h (right):

http://codereview.chromium.org/9158012/diff/1/chrome_frame/test/net/test_auto...
chrome_frame/test/net/test_automation_resource_message_filter.h:1: // Copyright
(c) 2009 The Chromium Authors. All rights reserved.
On 2012/01/10 19:56:44, grt wrote:
> 2012

Done.

[grt (UTC plus 2), 2012-01-10 20:38:08]

LGTM++ w/ 1 nit

http://codereview.chromium.org/9158012/diff/7002/chrome_frame/test/net/test_a...
File chrome_frame/test/net/test_automation_resource_message_filter.cc (right):

http://codereview.chromium.org/9158012/diff/7002/chrome_frame/test/net/test_a...
chrome_frame/test/net/test_automation_resource_message_filter.cc:46: //
URLRequestAutomationJob were created on, we could destroy the job on
were -> was

[commit-bot: I haz the power, 2012-01-11 01:15:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertshield@chromium.org/9158012/9001

[commit-bot: I haz the power, 2012-01-11 03:20:07]

Try job failure for 9158012-9001 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-01-11 18:24:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertshield@chromium.org/9158012/9001