Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 9158011: Fix dartc.sh script to use /bin/bash (issue dart:1104) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix script problem on buildbot (issue dart:1104( Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« compiler/scripts/dartc.sh ('K') | « compiler/scripts/dartc.sh ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 5ce6b7ebd94f01cc963a86a8a92704b3ad298115..50721c44ccce5ff0973b93c084c3eec6250e9010 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -103,7 +103,14 @@ class BrowserTestCase extends TestCase {
configuration,
completedHandler,
expectedOutcomes,
- isNegative);
+ isNegative) {
+ if (compilerPath != null) {
+ commandLine = 'execution command: $commandLine';
+ String compilationCommand =
+ '$compilerPath ${Strings.join(compilerArguments, " ")}';
+ commandLine = 'compilation command: $compilationCommand\n$commandLine';
+ }
+ }
}
@@ -186,9 +193,12 @@ class RunningProcess {
void compilerExitHandler(int exitCode) {
if (exitCode != 0) {
+ stderr.add('test.dart: Compilation step failed (exit code $exitCode)\n');
exitHandler(exitCode);
} else {
process.close();
+ stderr.add('test.dart: Compilation finished, starting execution\n');
+ stdout.add('test.dart: Compilation finished, starting execution\n');
runCommand(testCase.executablePath, testCase.arguments, exitHandler);
}
}
« compiler/scripts/dartc.sh ('K') | « compiler/scripts/dartc.sh ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698