chrome/browser/sync/engine/syncer_proto_util.h - Issue 9158004: Detect sync server communication errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/engine/syncer_proto_util.h

Issue 9158004: Detect sync server communication errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update for review comments Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/engine/syncer_proto_util.h

diff --git a/chrome/browser/sync/engine/syncer_proto_util.h b/chrome/browser/sync/engine/syncer_proto_util.h

index 0b209a7d752ea73640acbc1701ba9dc07c933ee8..6fdf31c655b68e4eded777d15e9a9bf07beb6840 100644

--- a/chrome/browser/sync/engine/syncer_proto_util.h

+++ b/chrome/browser/sync/engine/syncer_proto_util.h

@@ -10,6 +10,7 @@

#include "base/gtest_prod_util.h"

#include "base/time.h"

+#include "chrome/browser/sync/internal_api/includes/syncer_error.h"

#include "chrome/browser/sync/sessions/sync_session.h"

#include "chrome/browser/sync/syncable/blob.h"

#include "chrome/browser/sync/syncable/model_type.h"

@@ -42,7 +43,7 @@ class SyncerProtoUtil {

// Returns true on success. Also handles store birthday verification:

// session->status()->syncer_stuck_ is set true if the birthday is

// incorrect. A false value will always be returned if birthday is bad.

- static bool PostClientToServerMessage(

+ static SyncerError PostClientToServerMessage(

const ClientToServerMessage& msg,

sync_pb::ClientToServerResponse* response,

sessions::SyncSession* session);