Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3954)

Unified Diff: base/test/trace_event_analyzer.h

Issue 9155024: Allow tracing in third_party libraries (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: win compile Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/debug/trace_event_win.cc ('k') | base/test/trace_event_analyzer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/trace_event_analyzer.h
diff --git a/base/test/trace_event_analyzer.h b/base/test/trace_event_analyzer.h
index 949721b26bb714c44a2943c3d833dc5dcde593b5..4817ec846270727a4fe9f023634d0ba021356a8f 100644
--- a/base/test/trace_event_analyzer.h
+++ b/base/test/trace_event_analyzer.h
@@ -152,7 +152,7 @@ struct TraceEvent {
// Stored as double to match its JSON representation.
double timestamp;
- base::debug::TraceEventPhase phase;
+ char phase;
std::string category;
@@ -193,7 +193,7 @@ class Query {
static Query Bool(bool boolean);
// Compare with the given phase.
- static Query Phase(base::debug::TraceEventPhase phase);
+ static Query Phase(char phase);
// Compare with the given string pattern. Only works with == and != operators.
// Example: Query(EVENT_NAME) == Query::Pattern("MyEvent*")
@@ -424,10 +424,11 @@ class Query {
bool EvaluateArithmeticOperator(const TraceEvent& event,
double* num) const;
- // For QUERY_EVENT_MEMBER Query: attempt to get the value of the Query.
- // The TraceValue will either be TRACE_TYPE_DOUBLE, TRACE_TYPE_STRING,
- // or if requested member does not exist, it will be TRACE_TYPE_UNDEFINED.
- base::debug::TraceValue GetMemberValue(const TraceEvent& event) const;
+ // For QUERY_EVENT_MEMBER Query: attempt to get the double value of the Query.
+ bool GetMemberValueAsDouble(const TraceEvent& event, double* num) const;
+
+ // For QUERY_EVENT_MEMBER Query: attempt to get the string value of the Query.
+ bool GetMemberValueAsString(const TraceEvent& event, std::string* num) const;
// Does this Query represent a value?
bool is_value() const { return type_ != QUERY_BOOLEAN_OPERATOR; }
« no previous file with comments | « base/debug/trace_event_win.cc ('k') | base/test/trace_event_analyzer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698