Allow tracing in third_party libraries

base/debug/trace_event_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 

[jar (doing other things), 2012/01/12 00:15:36]

You added a lot of macros.  Shouldn't there be tests for them?

[jbates, 2012/01/12 00:52:20]

Done.

 #include "base/debug/trace_event.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/memory/ref_counted_memory.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/singleton.h"
 #include "base/process_util.h"
@@ skipping 77 matching lines @@
     const scoped_refptr<TraceLog::RefCountedString>& events_str) {
   AutoLock lock(lock_);
   json_output_.json_output.clear();
   trace_buffer_.Start();
   trace_buffer_.AddFragment(events_str->data);
   trace_buffer_.Finish();
 
   scoped_ptr<Value> root;
   root.reset(base::JSONReader::Read(json_output_.json_output, false));
 
+  if (!root.get()) {
+    LOG(ERROR) << json_output_.json_output;
+  }
+
   ListValue* root_list = NULL;
   ASSERT_TRUE(root.get());
   ASSERT_TRUE(root->GetAsList(&root_list));
 
   // Move items into our aggregate collection
   while (root_list->GetSize()) {
     Value* item = NULL;
     root_list->Remove(0, &item);
     trace_parsed_.Append(item);
   }
@@ skipping 1036 matching lines @@
   Clear();
 
   trace_buffer_.Start();
   trace_buffer_.AddFragment("bla1,bla2,bla3,bla4");
   trace_buffer_.Finish();
   EXPECT_STREQ(json_output_.json_output.c_str(), "[bla1,bla2,bla3,bla4]");
 }
 
 }  // namespace debug
 }  // namespace base