corelib/src/implementation/future_implementation.dart - Issue 9155017: Handle defered handling of exceptions (where the exception is thrown before the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: corelib/src/implementation/future_implementation.dart

Issue 9155017: Handle defered handling of exceptions (where the exception is thrown before the (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: quick typo fix Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: corelib/src/implementation/future_implementation.dart

diff --git a/corelib/src/implementation/future_implementation.dart b/corelib/src/implementation/future_implementation.dart

index 47c1e5d8c07ac628f806556c1f7e1b1e0de3fc1c..6f098148a010d9fc317995e29f5bfdef0f921246 100644

--- a/corelib/src/implementation/future_implementation.dart

+++ b/corelib/src/implementation/future_implementation.dart

@@ -91,7 +91,13 @@ class FutureImpl<T> implements Future<T> {

}

void handleException(void onException(Object exception)) {

- _exceptionHandlers.add(onException);

+ if (null !== _exception) {

Siggi Cherem (dart-lang) 2012/01/21 01:50:38 (swap): _expression !== null

+ if (!_exceptionHandled) {

+ _exceptionHandled = onException(exception);

+ }

+ } else {

+ _exceptionHandlers.add(onException);

+ }

}

void _complete() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »