Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: corelib/src/implementation/future_implementation.dart

Issue 9155017: Handle defered handling of exceptions (where the exception is thrown before the (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: corelib/src/implementation/future_implementation.dart
diff --git a/corelib/src/implementation/future_implementation.dart b/corelib/src/implementation/future_implementation.dart
index 47c1e5d8c07ac628f806556c1f7e1b1e0de3fc1c..d4b7ad0c958dc0ff9ee70ee6da7574743965e4a7 100644
--- a/corelib/src/implementation/future_implementation.dart
+++ b/corelib/src/implementation/future_implementation.dart
@@ -85,13 +85,15 @@ class FutureImpl<T> implements Future<T> {
onComplete(value);
} else if (!isComplete) {
_listeners.add(onComplete);
- } else if (!_exceptionHandled) {
Siggi Cherem (dart-lang) 2012/01/10 20:39:27 I believe we don't want to do this part of the cha
- throw _exception;
}
}
void handleException(void onException(Object exception)) {
- _exceptionHandlers.add(onException);
+ if (null !== _exception) {
Siggi Cherem (dart-lang) 2012/01/10 20:39:27 (nit): keeping the style consistent with the rest
+ if (!_exceptionHandled) _exceptionHandled = onException(exception);
+ } else {
+ _exceptionHandlers.add(onException);
+ }
}
void _complete() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698