Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
9155014:
Add HttpHeaders to experimental.downloads.json (Closed)
|
Created:
8 years, 11 months ago by cbentzel Modified:
8 years, 11 months ago CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionAdd HttpHeaders to experimental.downloads.json
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117303
Patch Set 1 #
Total comments: 1
Messages
Total messages: 11 (0 generated)
- No docs are in the CL since this API has the nodoc: True - HttpHeaders are also defined in webRequest.json. Is there a way to move it into a centralized library file rather than duplicating the definition?
lgtm
aa: Still need OWNERS approval. Also adding skerner who has been looking at it.
http://codereview.chromium.org/9155014/diff/1/chrome/common/extensions/api/ex... File chrome/common/extensions/api/experimental.downloads.json (right): http://codereview.chromium.org/9155014/diff/1/chrome/common/extensions/api/ex... chrome/common/extensions/api/experimental.downloads.json:87: "description": "An array of HTTP headers. Each header is represented as a dictionary containing the keys <code>name</code> and either <code>value</code> or <code>binaryValue</code>.", I have not seen HTML tags like <code> used in this file. When you generate the docs (chrome/common/extensions/docs/build/build.py) do they come through the process as proper HTML?
Right now no docs are generated (nodoc is set in the json). I'll modify locally to see what it looks like. Also, this was lifted wholesale from webRequest.json. I couldn't see an include-like functionality for this, and not sure if it makes sense. On Wed, Jan 11, 2012 at 11:21 AM, <skerner@chromium.org> wrote: > > http://codereview.chromium.**org/9155014/diff/1/chrome/** > common/extensions/api/**experimental.downloads.json<http://codereview.chromium.org/9155014/diff/1/chrome/common/extensions/api/experimental.downloads.json> > File chrome/common/extensions/api/**experimental.downloads.json (right): > > http://codereview.chromium.**org/9155014/diff/1/chrome/** > common/extensions/api/**experimental.downloads.json#**newcode87<http://codereview.chromium.org/9155014/diff/1/chrome/common/extensions/api/experimental.downloads.json#newcode87> > chrome/common/extensions/api/**experimental.downloads.json:**87: > > "description": "An array of HTTP headers. Each header is represented as > a dictionary containing the keys <code>name</code> and either > <code>value</code> or <code>binaryValue</code>.", > I have not seen HTML tags like <code> used in this file. When you > generate the docs (chrome/common/extensions/**docs/build/build.py) do they > come through the process as proper HTML? > > http://codereview.chromium.**org/9155014/<http://codereview.chromium.org/9155... >
The <code> elements do appear in the final document. On Wed, Jan 11, 2012 at 12:20 PM, Chris Bentzel <cbentzel@chromium.org>wrote: > Right now no docs are generated (nodoc is set in the json). I'll modify > locally to see what it looks like. > > Also, this was lifted wholesale from webRequest.json. I couldn't see an > include-like functionality for this, and not sure if it makes sense. > > > On Wed, Jan 11, 2012 at 11:21 AM, <skerner@chromium.org> wrote: > >> >> http://codereview.chromium.**org/9155014/diff/1/chrome/** >> common/extensions/api/**experimental.downloads.json<http://codereview.chromium.org/9155014/diff/1/chrome/common/extensions/api/experimental.downloads.json> >> File chrome/common/extensions/api/**experimental.downloads.json (right): >> >> http://codereview.chromium.**org/9155014/diff/1/chrome/** >> common/extensions/api/**experimental.downloads.json#**newcode87<http://codereview.chromium.org/9155014/diff/1/chrome/common/extensions/api/experimental.downloads.json#newcode87> >> chrome/common/extensions/api/**experimental.downloads.json:**87: >> >> "description": "An array of HTTP headers. Each header is represented as >> a dictionary containing the keys <code>name</code> and either >> <code>value</code> or <code>binaryValue</code>.", >> I have not seen HTML tags like <code> used in this file. When you >> generate the docs (chrome/common/extensions/**docs/build/build.py) do >> they >> come through the process as proper HTML? >> >> http://codereview.chromium.**org/9155014/<http://codereview.chromium.org/9155... >> > >
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbentzel@chromium.org/9155014/1
Try job failure for 9155014-1 (retry) on mac_rel for step "update". It's a second try, previously, step "ui_tests" failed. http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu... Step "update" is always a major failure. Look at the try server FAQ for more details.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbentzel@chromium.org/9155014/1
Change committed as 117303 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
