Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1807)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 9155001: Use test.dart for dartc buildbot. Ensure that test.dart creates the build directory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/multitest.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 85042c40a2372178f036f9c393f5d74b67b9058a..7d3f3f03e1fcf59d50a6a283c4bbaa591c4024f2 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -471,7 +471,9 @@ class StandardTestSuite implements TestSuite {
} else {
args = ['--no-timeout'];
if (component == 'dartium') {
- var dartFlags = ['--enable_asserts', '--enable_type_checks'];
+ var dartFlags = ['--enable_asserts',
+ '--enable_type_checks',
+ '--ignore-unrecognized-flags'];
dartFlags.addAll(vmOptions);
args.add('--dart-flags=${Strings.join(dartFlags, " ")}');
}
@@ -512,7 +514,22 @@ class StandardTestSuite implements TestSuite {
String tempDirPath = TestUtils.buildDir(configuration);
Directory tempDir = new Directory(tempDirPath);
if (!tempDir.existsSync()) {
- throw new Exception('Build directory $tempDirPath does not exist.');
+ // Dartium tests can be run with no build step, with no output directory.
+ // This special case builds the build directory that should be there.
+ var buildPath = tempDirPath.split('/');
+ tempDirPath = buildPath[0];
+ if (tempDirPath == '') {
+ throw new Exception(
+ 'Non-relative path to build directory in test_suite.dart');
+ }
+ buildPath.removeRange(0, 1);
+ if (buildPath.last() == '') buildPath.removeLast();
+ buildPath.addAll(generatedTestPath);
+ generatedTestPath = buildPath;
+ tempDir = new Directory(tempDirPath);
+ if (!tempDir.existsSync()) {
+ tempDir.createSync();
+ }
}
tempDirPath = new File(tempDirPath).fullPathSync();
« no previous file with comments | « tools/testing/dart/multitest.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698