Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 9154003: Pass Content-security-policy and header type from WebSharedWorkerProxy to WebSharedWorkerStub. (Closed)

Created:
8 years, 11 months ago by Tom Sepez
Modified:
8 years, 11 months ago
Reviewers:
jam, abarth-chromium
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Pass Content-security-policy and header type from WebSharedWorkerProxy to WebSharedWorkerStub now that webkit is updated. Step #2 of https://bugs.webkit.org/show_bug.cgi?id=75660#c15 BUG=105482 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118703

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -15 lines) Patch
M content/common/worker_messages.h View 1 2 3 chunks +7 lines, -2 lines 0 comments Download
M content/renderer/websharedworker_proxy.h View 1 2 2 chunks +16 lines, -0 lines 0 comments Download
M content/renderer/websharedworker_proxy.cc View 1 2 3 chunks +29 lines, -10 lines 0 comments Download
M content/worker/websharedworker_stub.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M content/worker/websharedworker_stub.cc View 1 2 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Tom Sepez
John, Adam, please take a look. Thanks heaps.
8 years, 11 months ago (2012-01-09 21:06:31 UTC) #1
abarth-chromium
Looks reasonable. http://codereview.chromium.org/9154003/diff/1/content/worker/websharedworker_stub.cc File content/worker/websharedworker_stub.cc (right): http://codereview.chromium.org/9154003/diff/1/content/worker/websharedworker_stub.cc#newcode91 content/worker/websharedworker_stub.cc:91: // FIXME(tsepez): pass CSP info into worker ...
8 years, 11 months ago (2012-01-09 21:15:57 UTC) #2
Tom Sepez
http://codereview.chromium.org/9154003/diff/1/content/worker/websharedworker_stub.cc File content/worker/websharedworker_stub.cc (right): http://codereview.chromium.org/9154003/diff/1/content/worker/websharedworker_stub.cc#newcode91 content/worker/websharedworker_stub.cc:91: // FIXME(tsepez): pass CSP info into worker once webkit ...
8 years, 11 months ago (2012-01-09 21:18:19 UTC) #3
jam
lgtm
8 years, 11 months ago (2012-01-09 21:53:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/9154003/6002
8 years, 11 months ago (2012-01-09 22:26:00 UTC) #5
commit-bot: I haz the power
Change committed as 116954
8 years, 11 months ago (2012-01-09 23:47:57 UTC) #6
Tom Sepez
John, please re-review: The patch landed at r116954 was reverted. This is the replacement for ...
8 years, 11 months ago (2012-01-19 19:10:26 UTC) #7
jam
rubberstamp lgtm
8 years, 11 months ago (2012-01-19 22:20:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/9154003/14001
8 years, 11 months ago (2012-01-19 22:22:17 UTC) #9
commit-bot: I haz the power
Try job failure for 9154003-14001 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 11 months ago (2012-01-20 00:14:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/9154003/14001
8 years, 11 months ago (2012-01-20 17:30:56 UTC) #11
commit-bot: I haz the power
Try job failure for 9154003-14001 (retry) on mac_rel for steps "browser_tests, ui_tests". It's a second ...
8 years, 11 months ago (2012-01-20 19:43:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/9154003/14001
8 years, 11 months ago (2012-01-20 22:16:57 UTC) #13
commit-bot: I haz the power
8 years, 11 months ago (2012-01-21 01:47:15 UTC) #14
Try job failure for 9154003-14001 (retry) on win_rel for steps "browser_tests,
ui_tests".
It's a second try, previously, steps "base_unittests, browser_tests, ui_tests"
failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698