Rewrote the clipboard API to be more concurrent. Added a helper class to make...

chrome/browser/download/download_util.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Download utility implementation
 
 #include <string>
 
 #include "chrome/browser/download/download_util.h"
 
 #include "base/base_drag_source.h"
 #include "base/file_util.h"
+#include "base/scoped_clipboard_writer.h"
 #include "base/gfx/image_operations.h"
 #include "chrome/app/theme/theme_resources.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/download/download_manager.h"
 #include "chrome/common/clipboard_service.h"
 #include "chrome/browser/drag_utils.h"
 #include "chrome/common/gfx/chrome_canvas.h"
 #include "chrome/common/l10n_util.h"
 #include "chrome/common/os_exchange_data.h"
 #include "chrome/common/resource_bundle.h"
@@ skipping 73 matching lines @@
     case ALWAYS_OPEN_TYPE:
       return CanOpenDownload(download_);
     case CANCEL:
       return download_->state() == DownloadItem::IN_PROGRESS;
     default:
       return id > 0 && id < MENU_LAST;
   }
 }
 
 void BaseContextMenu::ExecuteCommand(int id) {
-  ClipboardService* clipboard = g_browser_process->clipboard_service();
-  DCHECK(clipboard);
+  ScopedClipboardWriter scw(g_browser_process->clipboard_service());
   switch (id) {
     case SHOW_IN_FOLDER:
       download_->manager()->ShowDownloadInShell(download_);
       break;
     case COPY_LINK:
-      clipboard->Clear();
-      clipboard->WriteText(download_->url());
+      scw.WriteText(download_->url());
       break;
     case COPY_PATH:
-      clipboard->Clear();
-      clipboard->WriteText(download_->full_path());
+      scw.WriteText(download_->full_path());
       break;
     case COPY_FILE:
       // TODO(paulg): Move to OSExchangeData when implementing drag and drop?
-      clipboard->Clear();
-      clipboard->WriteFile(download_->full_path());
+      scw.WriteFile(download_->full_path());
       break;
     case OPEN_WHEN_COMPLETE:
       OpenDownload(download_);
       break;
     case ALWAYS_OPEN_TYPE: {
       const std::wstring extension =
           file_util::GetFileExtensionFromPath(download_->full_path());
       download_->manager()->OpenFilesOfExtension(
           extension, !IsItemChecked(ALWAYS_OPEN_TYPE));
       break;
@@ skipping 264 matching lines @@
 
   // Run the drag and drop loop
   DWORD effects;
   DoDragDrop(data.get(), drag_source.get(), DROPEFFECT_COPY | DROPEFFECT_LINK,
              &effects);
 }
 
 
 }  // namespace download_util