Issue 9154: Rewrote the clipboard API to be more concurrent. Added a helper class to make...

Issue 9154: Rewrote the clipboard API to be more concurrent. Added a helper class to make... (Closed)

Created:
12 years, 1 month ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Mark Mentovai, Peter Kasting, jeremy

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Rewrote the clipboard API to be more concurrent. Added a helper class to make it more foolproof. Updated all clients and unittests. Mac port by jeremy@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4719

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+871 lines, -548 lines)			Patch
M	base/base.xcodeproj/project.pbxproj	View	1	6 chunks	+10 lines, -0 lines	0 comments	Download
M	base/base_lib.scons	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	base/build/base.vcproj	View		2 chunks	+12 lines, -0 lines	0 comments	Download
M	base/clipboard.h	View		3 chunks	+102 lines, -59 lines	0 comments	Download
A	base/clipboard.cc	View		1 chunk	+55 lines, -0 lines	0 comments	Download
M	base/clipboard_linux.cc	View		3 chunks	+89 lines, -91 lines	0 comments	Download
M	base/clipboard_mac.mm	View		2 chunks	+53 lines, -25 lines	0 comments	Download
M	base/clipboard_unittest.cc	View		14 chunks	+72 lines, -48 lines	0 comments	Download
M	base/clipboard_win.cc	View		11 chunks	+106 lines, -101 lines	0 comments	Download
A	base/scoped_clipboard_writer.h	View		1 chunk	+62 lines, -0 lines	0 comments	Download
A	base/scoped_clipboard_writer.cc	View		1 chunk	+130 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/download/download_util.cc	View		2 chunks	+5 lines, -8 lines	0 comments	Download
M	chrome/browser/render_view_context_menu_controller.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/resource_message_filter.h	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/resource_message_filter.cc	View		3 chunks	+11 lines, -36 lines	0 comments	Download
M	chrome/common/clipboard_service.h	View		2 chunks	+4 lines, -10 lines	0 comments	Download
D	chrome/common/clipboard_service.cc	View		1 chunk	+0 lines, -20 lines	0 comments	Download
M	chrome/common/common.vcproj	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View		2 chunks	+9 lines, -14 lines	0 comments	Download
M	chrome/renderer/renderer_glue.cc	View		4 chunks	+67 lines, -52 lines	0 comments	Download
M	chrome/views/text_field.cc	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	webkit/build/glue/glue.vcproj	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A	webkit/glue/scoped_clipboard_writer_glue.h	View		1 chunk	+29 lines, -0 lines	0 comments	Download
M	webkit/glue/simple_clipboard_impl.cc	View		2 chunks	+13 lines, -28 lines	0 comments	Download
M	webkit/glue/webkit_glue.h	View		2 chunks	+3 lines, -19 lines	0 comments	Download
M	webkit/port/platform/win/PasteboardWin.cpp	View		4 chunks	+21 lines, -20 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

This is issue 9087 + 8889. I'm going to commit when the tree is open. ...

12 years, 1 month ago (2008-11-05 01:13:33 UTC) #1

Peter Kasting

12 years, 1 month ago (2008-11-05 05:23:28 UTC) #2

I also give rubber-stamp LGTM without looking at the change.

500 errors are usually transient.  You could try again now, or in an hour, or a
day.

Expand Messages | Collapse Messages