Issue 9153008: Progressively refacto FirstRun class to first_run namespace(part 4).

Issue 9153008: Progressively refacto FirstRun class to first_run namespace(part 4). (Closed)

Created:
8 years, 11 months ago by jennyz

Modified:
8 years, 11 months ago

Reviewers:
dmac, Elliot Glaysher, Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Progressively refacto FirstRun class to first_run namespace(part 4). BUG=108137 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117266

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -48 lines)			Patch
M	chrome/browser/first_run/first_run.h	View	3 chunks	+11 lines, -13 lines	0 comments	Download
M	chrome/browser/first_run/first_run.cc	View	4 chunks	+17 lines, -19 lines	0 comments	Download
M	chrome/browser/first_run/first_run_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/first_run/first_run_linux.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/first_run/first_run_mac.mm	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/first_run/first_run_win.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/cocoa/first_run_dialog.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/first_run_dialog.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/first_run_search_engine_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 9 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/9153008/1

8 years, 11 months ago (2012-01-11 18:24:46 UTC) #3

commit-bot: I haz the power

Presubmit check for 9153008-1 failed and returned exit status 1. Running presubmit commit checks ...

8 years, 11 months ago (2012-01-11 18:24:52 UTC) #4

jennyz

Adding OWNERS review for first_run_dialog.mm and first_run_dialog.cc

8 years, 11 months ago (2012-01-11 18:31:09 UTC) #5

dmac

On 2012/01/11 18:32:56, Elliot Glaysher wrote: > trvial owners stamp lgtm on the linux file. ...

8 years, 11 months ago (2012-01-11 18:46:08 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/9153008/1

8 years, 11 months ago (2012-01-11 18:49:13 UTC) #8

Change committed as 117266