Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2310)

Unified Diff: frog/value.dart

Issue 9151015: addressing 3 previous review comments (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: rebased Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « frog/tokenizer.dart ('k') | tests/language/language.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/value.dart
diff --git a/frog/value.dart b/frog/value.dart
index d557b8e596efbdef17e58376431896f1cacce570..d0ee5a909d3a3e71be19deb4abeecbafb66a227e 100644
--- a/frog/value.dart
+++ b/frog/value.dart
@@ -581,7 +581,11 @@ class EvaluatedValue extends Value implements Hashable {
EvaluatedValue(this.isConst, Type type, SourceSpan span):
super(type, '@@@', span, false);
- String get code() => '@@@';
+ String get code() {
+ world.internalError('Should not be getting code from raw EvaluatedValue',
+ span);
+ }
+
EvaluatedValue get constValue() => this;
@@ -937,7 +941,7 @@ class ListValue extends EvaluatedValue {
String get code() {
final buf = new StringBuffer();
buf.add('[');
- for (var i=0; i < values.length; i++) {
+ for (var i = 0; i < values.length; i++) {
if (i > 0) buf.add(', ');
buf.add(values[i].code);
}
« no previous file with comments | « frog/tokenizer.dart ('k') | tests/language/language.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698