Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 9151007: GTK: Seal up GSEALs, focusing on GtkSelectionData. (Closed)

Created:
8 years, 11 months ago by Elliot Glaysher
Modified:
8 years, 11 months ago
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, yusukes+watch_chromium.org, derat+watch_chromium.org, ajwong+watch_chromium.org, jam, penghuang+watch_chromium.org, dcheng, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, sadrul, James Su
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

GTK: Seal up GSEALs, focusing on GtkSelectionData. BUG=79722 TEST=compiles First Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116956 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117070

Patch Set 1 #

Patch Set 2 : Add gtk_widget_style_attach to make minimal version 2.18 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -59 lines) Patch
M chrome/browser/ui/gtk/bubble/bubble_gtk.cc View 1 5 chunks +10 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/certificate_viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/gtk_im_context_wrapper.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/tab_contents/web_drag_dest_gtk.cc View 1 5 chunks +12 lines, -10 lines 0 comments Download
M content/browser/tab_contents/web_drag_source_gtk.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/clipboard/clipboard_gtk.cc View 1 7 chunks +22 lines, -11 lines 0 comments Download
M ui/base/dragdrop/gtk_dnd_util.cc View 1 4 chunks +12 lines, -8 lines 0 comments Download
M ui/base/gtk/focus_store_gtk.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/gtk/gtk_compat.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ui/base/x/x11_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gtk_native_view_id_manager.cc View 1 5 chunks +7 lines, -6 lines 0 comments Download
M ui/gfx/gtk_preserve_window.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M ui/gfx/screen_gtk.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Elliot Glaysher
jhawkins: more porting work. sigh.
8 years, 11 months ago (2012-01-09 19:19:56 UTC) #1
James Hawkins
lgtm
8 years, 11 months ago (2012-01-09 19:26:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/9151007/1
8 years, 11 months ago (2012-01-09 19:27:16 UTC) #3
commit-bot: I haz the power
Presubmit check for 9151007-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 11 months ago (2012-01-09 19:27:30 UTC) #4
Elliot Glaysher
+jam: content/ stamp +sky: ui/ stamp
8 years, 11 months ago (2012-01-09 19:28:28 UTC) #5
jam
rubberstamp lgtm for content
8 years, 11 months ago (2012-01-09 21:52:01 UTC) #6
sky
LGTM
8 years, 11 months ago (2012-01-09 22:20:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/9151007/1
8 years, 11 months ago (2012-01-09 22:33:00 UTC) #8
commit-bot: I haz the power
Change committed as 116956
8 years, 11 months ago (2012-01-09 23:51:52 UTC) #9
Elliot Glaysher
+thestig: This fixes up the reverted patch so we add gtk_widget_style_attach() to gtk_compat.h. That's the ...
8 years, 11 months ago (2012-01-10 02:16:00 UTC) #10
Lei Zhang
LGTM
8 years, 11 months ago (2012-01-10 02:28:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/9151007/12001
8 years, 11 months ago (2012-01-10 17:30:49 UTC) #12
commit-bot: I haz the power
8 years, 11 months ago (2012-01-10 19:12:57 UTC) #13
Change committed as 117070

Powered by Google App Engine
This is Rietveld 408576698