content/browser/tab_contents/interstitial_page.cc - Issue 9150016: Move creation and ownership of ResourceDispatcherHost and PluginService to content. This gives a ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tab_contents/interstitial_page.cc

Issue 9150016: Move creation and ownership of ResourceDispatcherHost and PluginService to content. This gives a ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/resource_dispatcher_host.cc ('K') | « content/browser/renderer_host/resource_message_filter.cc ('k') | content/browser/tab_contents/tab_contents.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/tab_contents/interstitial_page.cc

===================================================================

--- content/browser/tab_contents/interstitial_page.cc (revision 116798)

+++ content/browser/tab_contents/interstitial_page.cc (working copy)

@@ -569,21 +569,17 @@

// The tab might not have a render_view_host if it was closed (in which case,

// we have taken care of the blocked requests when processing

// NOTIFY_RENDER_WIDGET_HOST_DESTROYED.

- // Also we need to test there is a ResourceDispatcherHost, as when unit-tests

- // we don't have one.

RenderViewHost* rvh = RenderViewHost::FromID(original_child_id_,

original_rvh_id_);

- if (!rvh ||

- !content::GetContentClient()->browser()->GetResourceDispatcherHost()) {

+ if (!rvh)

return;

- }

BrowserThread::PostTask(

BrowserThread::IO,

FROM_HERE,

base::Bind(

&ResourceRequestHelper,

- content::GetContentClient()->browser()->GetResourceDispatcherHost(),

+ ResourceDispatcherHost::Get(),

original_child_id_,

original_rvh_id_,

action));