Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1662)

Unified Diff: chrome/browser/extensions/sandboxed_extension_unpacker.cc

Issue 9150016: Move creation and ownership of ResourceDispatcherHost and PluginService to content. This gives a ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/sandboxed_extension_unpacker.cc
===================================================================
--- chrome/browser/extensions/sandboxed_extension_unpacker.cc (revision 116798)
+++ chrome/browser/extensions/sandboxed_extension_unpacker.cc (working copy)
@@ -163,14 +163,16 @@
SandboxedExtensionUnpacker::SandboxedExtensionUnpacker(
const FilePath& crx_path,
- ResourceDispatcherHost* rdh,
Extension::Location location,
int creation_flags,
SandboxedExtensionUnpackerClient* client)
: crx_path_(crx_path),
thread_identifier_(BrowserThread::ID_COUNT),
- rdh_(rdh), client_(client), got_response_(false),
- location_(location), creation_flags_(creation_flags) {
+ client_(client),
+ got_response_(false),
+ location_(location),
+ creation_flags_(creation_flags),
+ use_utility_process_(true) {
}
bool SandboxedExtensionUnpacker::CreateTempDirectory() {
@@ -239,7 +241,7 @@
//
// TODO(asargent) we shouldn't need to do this branch here - instead
// UtilityProcessHost should handle it for us. (http://crbug.com/19192)
- bool use_utility_process = rdh_ &&
+ bool use_utility_process = use_utility_process_ &&
!CommandLine::ForCurrentProcess()->HasSwitch(switches::kSingleProcess);
if (use_utility_process) {
// The utility process will have access to the directory passed to

Powered by Google App Engine
This is Rietveld 408576698