Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 9150013: Fix null deref when walking cert chain. (Closed)

Created:
8 years, 11 months ago by Cris Neckar
Modified:
8 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix null deref when walking cert chain. BUG=109664 TEST=N/A Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117080

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/safe_browsing/signature_util_win.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Cris Neckar
Can you please verify that this is safe. I didn't see a way that ditching ...
8 years, 11 months ago (2012-01-09 23:13:10 UTC) #1
Brian Ryner
Ryan, could you take a look at this? The particular crash here seems to be ...
8 years, 11 months ago (2012-01-09 23:25:49 UTC) #2
Ryan Sleevi
FWIW, it might be moving the NULL checks out of the for loop, simply because ...
8 years, 11 months ago (2012-01-10 00:54:47 UTC) #3
Cris Neckar
8 years, 11 months ago (2012-01-10 01:00:04 UTC) #4
> failed. Cris, if you have a repro you can share (via mailto:rsleevi@c.o)
that'd be
> great - I'd be very curious to dig in further on this.

I added you on the bug which has a repro attached. Try using Chrome to download
it if you want to see it in action :p

> But LGTM as a change...

Sounds good, I'll move the checks out of the loop and get this commited.

Powered by Google App Engine
This is Rietveld 408576698