Issue 9150011: Add some tests for dartdoc name reference resolution.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9150011: Add some tests for dartdoc name reference resolution. (Closed)

Created:
8 years, 11 months ago by nweiz

Modified:
8 years, 11 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add some tests for dartdoc name reference resolution. Currently these just test existing behavior, but the goal is to set the stage for adding more advanced resolution. TBR Committed: https://code.google.com/p/dart/source/detail?r=3117

Patch Set 1 #

Total comments: 1

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+81 lines, -9 lines)			Patch
M	utils/dartdoc/dartdoc.dart	View	4 chunks	+12 lines, -9 lines	1 comment	Download
M	utils/dartdoc/files.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	utils/dartdoc/test/dartdoc_tests.dart	View	2 chunks	+68 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

8 years, 11 months ago (2012-01-09 22:48:20 UTC) #2

One naming suggestion, otherwise LGTM.

http://codereview.chromium.org/9150011/diff/1/utils/dartdoc/dartdoc.dart
File utils/dartdoc/dartdoc.dart (right):

http://codereview.chromium.org/9150011/diff/1/utils/dartdoc/dartdoc.dart#newc...
utils/dartdoc/dartdoc.dart:785: md.Node resolveNameReference(String name,
[Member currentMember = null,
I wouldn't use "current", just "member", "type" and "library".

Expand Messages | Collapse Messages