Introduce background.scripts feature for extension manifests.

chrome/common/extensions/extension.cc

Index: chrome/common/extensions/extension.cc
diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc
index 10c849e20d20e37006f721116996baf3484b12dc..98727ba9769eb209ea31a22ab77fe7da72839303 100644
--- a/chrome/common/extensions/extension.cc
+++ b/chrome/common/extensions/extension.cc
@@ -373,6 +373,15 @@ GURL Extension::GetResourceURL(const GURL& extension_url,
   return ret_val;
 }
 
+GURL Extension::GetBackgroundURL() const {
+  if (!background_scripts_.empty()) {
+    return GetResourceURL(
+        extension_filenames::kGeneratedBackgroundPageFilename);
+  } else {
+    return background_url_;
+  }
+}
+
 bool Extension::IsResourceWebAccessible(const std::string& relative_path)
     const {
   // For old manifest versions which do not specify web_accessible_resources
@@ -1189,6 +1198,33 @@ bool Extension::LoadWebIntentServices(const extensions::Manifest* manifest,
   return true;
 }
 
+bool Extension::LoadBackgroundScripts(const extensions::Manifest* manifest,
+                                      string16* error) {
+  Value* background_scripts_value = NULL;
+  if (!manifest->Get(keys::kBackgroundScripts, &background_scripts_value))
+    return true;
+
+  CHECK(background_scripts_value);
+  if (background_scripts_value->GetType() != Value::TYPE_LIST) {
+    *error = ASCIIToUTF16(errors::kInvalidBackgroundScripts);
+    return false;
+  }
+
+  ListValue* background_scripts =
+      static_cast<ListValue*>(background_scripts_value);
+  for (size_t i = 0; i < background_scripts->GetSize(); ++i) {
+    std::string script;
+    if (!background_scripts->GetString(i, &script)) {
+      *error = ExtensionErrorUtils::FormatErrorMessageUTF16(
+          errors::kInvalidBackgroundScript, base::IntToString(i));
+      return false;
+    }
+    background_scripts_.push_back(script);

[Mihai Parparita -not on Chrome, 2012/01/10 01:51:37]

Drive by: Do you want to validate that these are relative paths only? It looks
like "background": {"scripts": ["http://www.mysite.com/script.js"]] will result
in a <script> tag pointed at that URL being generated. Though maybe that's OK,
because of CSP?

+  }
+
+  return true;
+}
+
 bool Extension::LoadBackgroundPage(
     const extensions::Manifest* manifest,
     const ExtensionAPIPermissionSet& api_permissions,
@@ -1208,6 +1244,11 @@ bool Extension::LoadBackgroundPage(
     return false;
   }
 
+  if (!background_scripts_.empty()) {
+    *error = ASCIIToUTF16(errors::kInvalidBackgroundCombination);
+    return false;
+  }
+
   if (is_hosted_app()) {
     // Make sure "background" permission is set.
     if (!api_permissions.count(ExtensionAPIPermission::kBackground)) {
@@ -1970,6 +2011,9 @@ bool Extension::InitFromValue(extensions::Manifest* manifest, int flags,
     }
   }
 
+  if (!LoadBackgroundScripts(manifest, error))
+    return false;
+
   if (!LoadBackgroundPage(manifest, api_permissions, error))
     return false;