Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4865)

Unified Diff: chrome/browser/sync/engine/syncer_unittest.cc

Issue 9149017: Remove broken variables from sync's AllStatus (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix sync_unit_test failure Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/engine/syncer_unittest.cc
diff --git a/chrome/browser/sync/engine/syncer_unittest.cc b/chrome/browser/sync/engine/syncer_unittest.cc
index 611aabf4a6c8ea3f8cbc0670ed8ed172a5c2ebdd..d9927fd3b028bbe717a70b2d117e8f867d24776e 100644
--- a/chrome/browser/sync/engine/syncer_unittest.cc
+++ b/chrome/browser/sync/engine/syncer_unittest.cc
@@ -1699,19 +1699,6 @@ TEST_F(SyncerTest, UpdateWithZeroLengthName) {
SyncShareAsDelegate();
}
-TEST_F(SyncerTest, DontGetStuckWithTwoSameNames) {
- // We should not get stuck here because we get
- // two server updates with exactly the same name.
- ScopedDirLookup dir(syncdb_.manager(), syncdb_.name());
- ASSERT_TRUE(dir.good());
- mock_server_->AddUpdateDirectory(1, 0, "foo:", 1, 10);
- SyncShareAsDelegate();
- mock_server_->AddUpdateDirectory(2, 0, "foo:", 1, 20);
- SyncRepeatedlyToTriggerStuckSignal(session_.get());
- EXPECT_FALSE(session_->status_controller().syncer_status().syncer_stuck);
- saw_syncer_event_ = false;
-}
-
TEST_F(SyncerTest, TestBasicUpdate) {
ScopedDirLookup dir(syncdb_.manager(), syncdb_.name());
ASSERT_TRUE(dir.good());
@@ -3254,23 +3241,6 @@ TEST_F(SyncerTest, MergingExistingItems) {
SyncRepeatedlyToTriggerConflictResolution(session_.get());
}
-TEST_F(SyncerTest, OneBajillionUpdates) {
- ScopedDirLookup dir(syncdb_.manager(), syncdb_.name());
- CHECK(dir.good());
- int one_bajillion = 4000;
-
- syncable::Id parent_id = ids_.MakeServer("Parent");
- mock_server_->AddUpdateDirectory(parent_id, ids_.root(), "foo", 1, 1);
-
- for (int i = 1; i <= one_bajillion; ++i) {
- syncable::Id item_id = ids_.FromNumber(i);
- mock_server_->AddUpdateDirectory(item_id, parent_id, "dude", 1, 1);
- }
-
- syncer_->SyncShare(session_.get(), SYNCER_BEGIN, SYNCER_END);
- EXPECT_FALSE(session_->status_controller().syncer_status().syncer_stuck);
-}
-
// In this test a long changelog contains a child at the start of the changelog
// and a parent at the end. While these updates are in progress the client would
// appear stuck.
@@ -3298,7 +3268,6 @@ TEST_F(SyncerTest, LongChangelistWithApplicationConflict) {
}
syncer_->SyncShare(session_.get(), SYNCER_BEGIN, SYNCER_END);
- EXPECT_FALSE(session_->status_controller().syncer_status().syncer_stuck);
// Ensure our folder hasn't somehow applied.
{
« no previous file with comments | « chrome/browser/sync/engine/syncer_proto_util.h ('k') | chrome/browser/sync/internal_api/debug_info_event_listener.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698