Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: chrome/browser/sync/sync_ui_util.cc

Issue 9149017: Remove broken variables from sync's AllStatus (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix sync_unit_test failure Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/sync/sessions/status_controller_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/sync_ui_util.h" 5 #include "chrome/browser/sync/sync_ui_util.h"
6 6
7 #include "base/i18n/number_formatting.h" 7 #include "base/i18n/number_formatting.h"
8 #include "base/i18n/time_formatting.h" 8 #include "base/i18n/time_formatting.h"
9 #include "base/string_util.h" 9 #include "base/string_util.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
(...skipping 519 matching lines...) Expand 10 before | Expand all | Expand 10 after
530 details, 530 details,
531 "Client ID", 531 "Client ID",
532 full_status.unique_id.empty() ? "none" : full_status.unique_id); 532 full_status.unique_id.empty() ? "none" : full_status.unique_id);
533 sync_ui_util::AddBoolSyncDetail(details, 533 sync_ui_util::AddBoolSyncDetail(details,
534 "Server Up", 534 "Server Up",
535 full_status.server_up); 535 full_status.server_up);
536 sync_ui_util::AddBoolSyncDetail(details, 536 sync_ui_util::AddBoolSyncDetail(details,
537 "Server Reachable", 537 "Server Reachable",
538 full_status.server_reachable); 538 full_status.server_reachable);
539 sync_ui_util::AddBoolSyncDetail(details, 539 sync_ui_util::AddBoolSyncDetail(details,
540 "Server Broken",
541 full_status.server_broken);
542 sync_ui_util::AddBoolSyncDetail(details,
543 "Notifications Enabled", 540 "Notifications Enabled",
544 full_status.notifications_enabled); 541 full_status.notifications_enabled);
545 sync_ui_util::AddIntSyncDetail(details, 542 sync_ui_util::AddIntSyncDetail(details,
546 "Notifications Received", 543 "Notifications Received",
547 full_status.notifications_received); 544 full_status.notifications_received);
548 sync_ui_util::AddIntSyncDetail(details, 545 sync_ui_util::AddIntSyncDetail(details,
549 "Notifiable Commits", 546 "Notifiable Commits",
550 full_status.notifiable_commits); 547 full_status.notifiable_commits);
551 sync_ui_util::AddIntSyncDetail(details, 548 sync_ui_util::AddIntSyncDetail(details,
552 "Unsynced Count", 549 "Unsynced Count",
553 full_status.unsynced_count); 550 full_status.unsynced_count);
554 sync_ui_util::AddIntSyncDetail(details, 551 sync_ui_util::AddIntSyncDetail(details,
555 "Conflicting Count", 552 "Conflicting Count",
556 full_status.conflicting_count); 553 full_status.conflicting_count);
557 sync_ui_util::AddIntSyncDetail(details, 554 sync_ui_util::AddIntSyncDetail(details,
558 "Local Overwrites", 555 "Local Overwrites",
559 full_status.num_local_overwrites_total); 556 full_status.num_local_overwrites_total);
560 sync_ui_util::AddIntSyncDetail(details, 557 sync_ui_util::AddIntSyncDetail(details,
561 "Server Overwrites", 558 "Server Overwrites",
562 full_status.num_server_overwrites_total); 559 full_status.num_server_overwrites_total);
563 sync_ui_util::AddBoolSyncDetail(details, "Syncing", full_status.syncing); 560 sync_ui_util::AddBoolSyncDetail(details, "Syncing", full_status.syncing);
564 sync_ui_util::AddBoolSyncDetail(details, 561 sync_ui_util::AddBoolSyncDetail(details,
565 "Initial Sync Ended", 562 "Initial Sync Ended",
566 full_status.initial_sync_ended); 563 full_status.initial_sync_ended);
567 sync_ui_util::AddBoolSyncDetail(details,
568 "Syncer Stuck",
569 full_status.syncer_stuck);
570 sync_ui_util::AddIntSyncDetail(details, 564 sync_ui_util::AddIntSyncDetail(details,
571 "Updates Available", 565 "Updates Available",
572 full_status.updates_available); 566 full_status.updates_available);
573 sync_ui_util::AddIntSyncDetail(details, 567 sync_ui_util::AddIntSyncDetail(details,
574 "Updates Downloaded (All)", 568 "Updates Downloaded (All)",
575 full_status.updates_received); 569 full_status.updates_received);
576 sync_ui_util::AddIntSyncDetail(details, 570 sync_ui_util::AddIntSyncDetail(details,
577 "Updates Downloaded (Tombstones)", 571 "Updates Downloaded (Tombstones)",
578 full_status.tombstone_updates_received); 572 full_status.tombstone_updates_received);
579 sync_ui_util::AddBoolSyncDetail(details,
580 "Disk Full",
581 full_status.disk_full);
582 sync_ui_util::AddIntSyncDetail(details, 573 sync_ui_util::AddIntSyncDetail(details,
583 "Max Consecutive Errors", 574 "Max Consecutive Errors",
584 full_status.max_consecutive_errors); 575 full_status.max_consecutive_errors);
585 sync_ui_util::AddIntSyncDetail(details, 576 sync_ui_util::AddIntSyncDetail(details,
586 "Empty GetUpdates", 577 "Empty GetUpdates",
587 full_status.empty_get_updates); 578 full_status.empty_get_updates);
588 sync_ui_util::AddIntSyncDetail(details, 579 sync_ui_util::AddIntSyncDetail(details,
589 "Nonempty GetUpdates", 580 "Nonempty GetUpdates",
590 full_status.nonempty_get_updates); 581 full_status.nonempty_get_updates);
591 sync_ui_util::AddIntSyncDetail(details, 582 sync_ui_util::AddIntSyncDetail(details,
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
706 } 697 }
707 } else { 698 } else {
708 version_modifier = " " + version_modifier; 699 version_modifier = " " + version_modifier;
709 } 700 }
710 return chrome_version.Name() + " " + chrome_version.OSType() + " " + 701 return chrome_version.Name() + " " + chrome_version.OSType() + " " +
711 chrome_version.Version() + " (" + chrome_version.LastChange() + ")" + 702 chrome_version.Version() + " (" + chrome_version.LastChange() + ")" +
712 version_modifier; 703 version_modifier;
713 } 704 }
714 705
715 } // namespace sync_ui_util 706 } // namespace sync_ui_util
OLDNEW
« no previous file with comments | « chrome/browser/sync/sessions/status_controller_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698