runtime/vm/handles_impl.h - Issue 9148051: Provide API support for weak handles and post-mortem finalization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/handles_impl.h

Issue 9148051: Provide API support for weak handles and post-mortem finalization. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: address review comments Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/handles_impl.h

diff --git a/runtime/vm/handles_impl.h b/runtime/vm/handles_impl.h

index 3e58c959a106330f209b38e600cb43f85691b076..4b70a76266e128daf50881c2184a1c873ecca812 100644

--- a/runtime/vm/handles_impl.h

+++ b/runtime/vm/handles_impl.h

@@ -303,7 +303,7 @@ void Handles<kHandleSizeInWords,

kOffsetOfRawPtr>::HandlesBlock::Visit(HandleVisitor* visitor) {

ASSERT(visitor != NULL);

for (intptr_t i = 0; i < next_handle_slot_; i += kHandleSizeInWords) {

- visitor->Visit(&data_[i + kOffsetOfRawPtr/kWordSize]);

+ visitor->VisitHandle(reinterpret_cast<uword>(&data_[i]));

}

« no previous file with comments | « runtime/vm/handles.h ('k') | runtime/vm/isolate.h » ('j') | no next file with comments »