Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 9148047: Patch required to build SDL against the latest ppapi headers (Closed)

Created:
8 years, 11 months ago by robertm
Modified:
8 years, 11 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Patch required to build SDL against the latest ppapi headers. This works around the problem that more recent ppapi version have moved the declaration of CallbackFactories form: ppapi/cpp/completion_callback.h to the new file: ppapi/utility/completion_callback_factory.h This causes quite a bit of headache in nacl-ports as we build it with a large variety of SDKs which all have different sets of ppapi headers. For now we (ab)use a versioned symbol from pp_var to control the the include behavior. This could be made somewhat cleaner if ppapi exported a number symbol based on the say the svn rev, e.g. #define PPPAI_VERSION_CONTROL_NO 9123456 which could be use in nacl-ports lik so: #if PPPAI_VERSION_CONTROL_NO > x BUG= http://code.google.com/p/naclports/issues/detail?id=27 Committed: https://code.google.com/p/naclports/source/detail?r=519

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M libraries/SDL-1.2.14/nacl-SDL-1.2.14.patch View 1 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
robertm
PTAL
8 years, 11 months ago (2012-01-20 17:56:14 UTC) #1
bradn
8 years, 11 months ago (2012-01-20 19:05:51 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698