Add NaCl proxy for pepper gamepad

Add NaCl proxy for pepper gamepad

BUG=79098
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117561

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117657

[scottmg, 2012-01-11 23:37:01]

First pass at adding ppapi_proxy for gamepad. Could you take a look to make sure
I'm not too far off in the weeds?

[bbudge, 2012-01-11 23:52:13]

On 2012/01/11 23:37:01, scottmg wrote:
> First pass at adding ppapi_proxy for gamepad. Could you take a look to make
sure
> I'm not too far off in the weeds?

It looks fine to me. Have you thought about tests?

[bbudge, 2012-01-11 23:52:59]

http://codereview.chromium.org/9148044/diff/1/ppapi/native_client/src/shared/...
File ppapi/native_client/src/shared/ppapi_proxy/browser_globals.cc (right):

http://codereview.chromium.org/9148044/diff/1/ppapi/native_client/src/shared/...
ppapi/native_client/src/shared/ppapi_proxy/browser_globals.cc:381:
GetBrowserInterfaceSafe(PPB_GAMEPAD_DEV_INTERFACE));
nit: indentation

http://codereview.chromium.org/9148044/diff/1/ppapi/native_client/src/shared/...
File
ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_gamepad_rpc_server.cc
(right):

http://codereview.chromium.org/9148044/diff/1/ppapi/native_client/src/shared/...
ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_gamepad_rpc_server.cc:1:
// Copyright (c) 2011 The Chromium Authors. All rights reserved.
2012

[scottmg, 2012-01-11 23:56:30]

On 2012/01/11 23:52:13, bbudge1 wrote:
> On 2012/01/11 23:37:01, scottmg wrote:
> > First pass at adding ppapi_proxy for gamepad. Could you take a look to make
> sure
> > I'm not too far off in the weeds?
> 
> It looks fine to me. Have you thought about tests?

Thanks. I wasn't too sure if there was a good way to mock data (or at what level
to do it). I was planning to do an example in native_client_sdk to manually
verify as a first step anyway.

[scottmg, 2012-01-11 23:58:25]

http://codereview.chromium.org/9148044/diff/1/ppapi/native_client/src/shared/...
File ppapi/native_client/src/shared/ppapi_proxy/browser_globals.cc (right):

http://codereview.chromium.org/9148044/diff/1/ppapi/native_client/src/shared/...
ppapi/native_client/src/shared/ppapi_proxy/browser_globals.cc:381:
GetBrowserInterfaceSafe(PPB_GAMEPAD_DEV_INTERFACE));
On 2012/01/11 23:52:59, bbudge1 wrote:
> nit: indentation

Done.

http://codereview.chromium.org/9148044/diff/1/ppapi/native_client/src/shared/...
File
ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_gamepad_rpc_server.cc
(right):

http://codereview.chromium.org/9148044/diff/1/ppapi/native_client/src/shared/...
ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_gamepad_rpc_server.cc:1:
// Copyright (c) 2011 The Chromium Authors. All rights reserved.
On 2012/01/11 23:52:59, bbudge1 wrote:
> 2012

Done.

[bbudge, 2012-01-12 00:52:22]

LGTM. I recommend you at least manually test this before committing.

[scottmg, 2012-01-12 22:34:43]

On 2012/01/12 00:52:22, bbudge1 wrote:
> LGTM. I recommend you at least manually test this before committing.

Thanks. Have confirmed that it works locally with patch set 3. Will work up an
example separately.

[commit-bot: I haz the power, 2012-01-12 22:35:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/9148044/4002

[commit-bot: I haz the power, 2012-01-13 00:16:04]

Change committed as 117561

[commit-bot: I haz the power, 2012-01-13 17:15:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/9148044/9001

[commit-bot: I haz the power, 2012-01-13 18:31:37]

Change committed as 117657