Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 9148039: Convert use of int ms to TimeDelta in files owned by jeremy. (Closed)

Created:
8 years, 11 months ago by Ted Vessenes
Modified:
8 years, 11 months ago
Reviewers:
jeremy
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Convert use of int ms to TimeDelta in files owned by jeremy. R=jeremy@chromium.org BUG=108171 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117557

Patch Set 1 #

Patch Set 2 : Remove static class initialization. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M ipc/ipc_fuzzing_tests.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ipc/ipc_logging.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_tests.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Ted Vessenes
8 years, 11 months ago (2012-01-11 22:19:50 UTC) #1
jeremy
LGTM Thanks for doing this! :)
8 years, 11 months ago (2012-01-12 11:15:48 UTC) #2
Ted Vessenes
I've recently learned that static initialization of class instances are prohibited, so I've uploaded a ...
8 years, 11 months ago (2012-01-12 19:16:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/9148039/1005
8 years, 11 months ago (2012-01-12 19:16:40 UTC) #4
commit-bot: I haz the power
Try job failure for 9148039-1005 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 11 months ago (2012-01-12 20:26:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/9148039/1005
8 years, 11 months ago (2012-01-12 22:19:23 UTC) #6
commit-bot: I haz the power
8 years, 11 months ago (2012-01-13 00:11:02 UTC) #7
Change committed as 117557

Powered by Google App Engine
This is Rietveld 408576698