Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7549)

Unified Diff: chrome/browser/ui/cocoa/web_intent_picker_cocoa.h

Issue 9148032: [Web Intents] Refactor picker to use WebIntentPickerModel. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: groby's fix Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/web_intent_picker_cocoa.h
diff --git a/chrome/browser/ui/cocoa/web_intent_picker_cocoa.h b/chrome/browser/ui/cocoa/web_intent_picker_cocoa.h
index 29eba4a3f88a61168ade241f41841f91f3b07192..b0deb420619a1bacb82aaba77b2da1b58f9da706 100644
--- a/chrome/browser/ui/cocoa/web_intent_picker_cocoa.h
+++ b/chrome/browser/ui/cocoa/web_intent_picker_cocoa.h
@@ -10,19 +10,23 @@
#include "base/compiler_specific.h"
#include "base/memory/scoped_ptr.h"
#include "chrome/browser/ui/intents/web_intent_picker.h"
+#include "chrome/browser/ui/intents/web_intent_picker_model.h"
+#include "chrome/browser/ui/intents/web_intent_picker_model_observer.h"
class InlineHtmlContentDelegate;
class TabContentsWrapper;
@class WebIntentBubbleController;
// A bridge class that enables communication between ObjectiveC and C++.
-class WebIntentPickerCocoa : public WebIntentPicker {
+class WebIntentPickerCocoa : public WebIntentPicker,
+ public WebIntentPickerModelObserver {
public:
// |browser| and |delegate| cannot be NULL.
// |wrapper| is unused.
WebIntentPickerCocoa(Browser* browser,
TabContentsWrapper* wrapper,
- WebIntentPickerDelegate* delegate);
+ WebIntentPickerDelegate* delegate,
+ WebIntentPickerModel* model);
virtual ~WebIntentPickerCocoa();
// WebIntentPickerDelegate forwarding API.
@@ -32,16 +36,21 @@ class WebIntentPickerCocoa : public WebIntentPicker {
void set_controller(WebIntentBubbleController* controller);
// WebIntentPicker:
- virtual void SetServiceURLs(const std::vector<GURL>& urls) OVERRIDE;
- virtual void SetServiceIcon(size_t index, const SkBitmap& icon) OVERRIDE;
- virtual void SetDefaultServiceIcon(size_t index) OVERRIDE;
virtual void Close() OVERRIDE;
- virtual content::WebContents* SetInlineDisposition(const GURL& url) OVERRIDE;
+
+ // WebIntentPickerModelObserver implementation.
+ virtual void OnModelChanged(WebIntentPickerModel* model) OVERRIDE;
+ virtual void OnFaviconChanged(WebIntentPickerModel* model,
+ size_t index) OVERRIDE;
+ virtual void OnInlineDisposition(WebIntentPickerModel* model) OVERRIDE;
private:
// Weak pointer to the |delegate_| to notify about user choice/cancellation.
WebIntentPickerDelegate* delegate_;
+ // The picker model. Weak reference.
+ WebIntentPickerModel* model_;
+
Browser* browser_; // The browser we're in. Weak Reference.
WebIntentBubbleController* controller_; // Weak reference.
« no previous file with comments | « chrome/browser/ui/cocoa/web_intent_bubble_controller_unittest.mm ('k') | chrome/browser/ui/cocoa/web_intent_picker_cocoa.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698