Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java

Issue 9148026: Recompile unit with potential conflict/dependency on some top-level symbol. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Restore "holes". Tests for them. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
diff --git a/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java b/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
index 3c394b136a5e258215eedf1fdd2d09ea10825bdb..a453449c05fc5a5e4b0c308e87fb188fc82a74f4 100644
--- a/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
+++ b/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
@@ -11,6 +11,7 @@ import com.google.common.collect.Iterables;
import com.google.dart.compiler.CompilerTestCase;
import com.google.dart.compiler.DartCompilationError;
import com.google.dart.compiler.ast.DartClass;
+import com.google.dart.compiler.ast.DartExprStmt;
import com.google.dart.compiler.ast.DartFunctionExpression;
import com.google.dart.compiler.ast.DartIdentifier;
import com.google.dart.compiler.ast.DartInvocation;
@@ -20,6 +21,8 @@ import com.google.dart.compiler.ast.DartNode;
import com.google.dart.compiler.ast.DartNodeTraverser;
import com.google.dart.compiler.ast.DartParameter;
import com.google.dart.compiler.ast.DartUnit;
+import com.google.dart.compiler.ast.DartUnqualifiedInvocation;
+import com.google.dart.compiler.common.Symbol;
import com.google.dart.compiler.parser.ParserErrorCode;
import com.google.dart.compiler.resolver.ClassElement;
import com.google.dart.compiler.resolver.Element;
@@ -514,4 +517,35 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
libraryResult.getCompilationErrors(),
errEx(ResolverErrorCode.DUPLICATE_NAMED_ARGUMENT, 16, 25, 5));
}
+
+ public void test_bindToLibraryFunctionFirst() throws Exception {
+ AnalyzeLibraryResult libraryResult =
+ analyzeLibrary(
+ getName(),
+ makeCode(
+ "// filler filler filler filler filler filler filler filler filler filler",
+ "foo() {}",
+ "class A {",
+ " foo() {}",
+ "}",
+ "class B extends A {",
+ " bar() {",
+ " foo();",
+ " }",
+ "}",
+ ""));
+ DartUnit unit = libraryResult.getLibraryUnitResult().getUnit(getName());
+ // Find foo() invocation.
+ DartUnqualifiedInvocation invocation;
+ {
+ DartClass classB = (DartClass) unit.getTopLevelNodes().get(2);
+ DartMethodDefinition methodBar = (DartMethodDefinition) classB.getMembers().get(0);
+ DartExprStmt stmt = (DartExprStmt) methodBar.getFunction().getBody().getStatements().get(0);
+ invocation = (DartUnqualifiedInvocation) stmt.getExpression();
+ }
+ // Check that unqualified foo() invocation is resolved to the top-level (library) function.
+ Symbol symbol = invocation.getTarget().getSymbol();
+ assertNotNull(symbol);
+ assertSame(unit, symbol.getNode().getParent());
+ }
}

Powered by Google App Engine
This is Rietveld 408576698