Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Unified Diff: net/http/http_proxy_client_socket.h

Issue 9148011: Allow chrome to handle 407 auth challenges to CONNECT requests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_network_transaction_unittest.cc ('k') | net/http/http_proxy_client_socket.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_proxy_client_socket.h
===================================================================
--- net/http/http_proxy_client_socket.h (revision 118888)
+++ net/http/http_proxy_client_socket.h (working copy)
@@ -27,7 +27,6 @@
class AddressList;
class ClientSocketHandle;
class GrowableIOBuffer;
-class HttpAuthCache;
class HttpStream;
class HttpStreamParser;
class IOBuffer;
@@ -42,8 +41,7 @@
const std::string& user_agent,
const HostPortPair& endpoint,
const HostPortPair& proxy_server,
- HttpAuthCache* http_auth_cache,
- HttpAuthHandlerFactory* http_auth_handler_factory,
+ HttpAuthController* http_auth_controller,
bool tunnel,
bool using_spdy,
SSLClientSocket::NextProto protocol_negotiated,
@@ -52,15 +50,6 @@
// On destruction Disconnect() is called.
virtual ~HttpProxyClientSocket();
- // If Connect (or its callback) returns PROXY_AUTH_REQUESTED, then
- // credentials should be added to the HttpAuthController before calling
- // RestartWithAuth.
- int RestartWithAuth(const CompletionCallback& callback);
-
- const scoped_refptr<HttpAuthController>& auth_controller() {
- return auth_;
- }
-
bool using_spdy() {
return using_spdy_;
}
@@ -72,6 +61,8 @@
// ProxyClientSocket implementation.
virtual const HttpResponseInfo* GetConnectResponseInfo() const OVERRIDE;
virtual HttpStream* CreateConnectResponseStream() OVERRIDE;
+ virtual int RestartWithAuth(const CompletionCallback& callback) OVERRIDE;
+ virtual const scoped_refptr<HttpAuthController>& GetAuthController() OVERRIDE;
// StreamSocket implementation.
virtual int Connect(const CompletionCallback& callback) OVERRIDE;
@@ -109,8 +100,6 @@
STATE_READ_HEADERS_COMPLETE,
STATE_DRAIN_BODY,
STATE_DRAIN_BODY_COMPLETE,
- STATE_TCP_RESTART,
- STATE_TCP_RESTART_COMPLETE,
STATE_DONE,
};
@@ -122,8 +111,6 @@
int PrepareForAuthRestart();
int DidDrainBodyForAuthRestart(bool keep_alive);
- int HandleAuthChallenge();
-
void LogBlockedTunnelResponse(int response_code) const;
void DoCallback(int result);
« no previous file with comments | « net/http/http_network_transaction_unittest.cc ('k') | net/http/http_proxy_client_socket.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698