Allow chrome to handle 407 auth challenges to CONNECT requests

jingle/notifier/base/proxy_resolving_client_socket.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "jingle/notifier/base/proxy_resolving_client_socket.h"
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/compiler_specific.h"
@@ skipping 154 matching lines @@
       CloseTransportSocket();
       RunUserConnectCallback(status);
       return;
     }
   }
 
   transport_.reset(new net::ClientSocketHandle);
   // Now that we have resolved the proxy, we need to connect.
   status = net::InitSocketHandleForRawConnect(
       dest_host_port_pair_, network_session_.get(), proxy_info_, ssl_config_,
-      ssl_config_, bound_net_log_, transport_.get(), connect_callback_);
+      ssl_config_, bound_net_log_, transport_.get(), connect_callback_,
+      base::Bind(&ProxyResolvingClientSocket::OnNeedsProxyTunnelAuthCallback,
+                 weak_factory_.GetWeakPtr()));
+
   if (status != net::ERR_IO_PENDING) {
     // Since this method is always called asynchronously. it is OK to call
     // ProcessConnectDone synchronously.
     ProcessConnectDone(status);
   }
 }
 
+void ProxyResolvingClientSocket::OnNeedsProxyTunnelAuthCallback(

[akalin, 2012/01/19 22:12:48]

actually, since this function doesn't do much, it can be a free function in an
anonymous namespace in this .cc file.  Then you can revert the change to the .h
file, and you wouldn't need the weak ptr at all.

[Ryan Hamilton, 2012/01/19 23:11:19]

Done.  (Love it!)

+    const net::HttpResponseInfo& response_info,
+    net::HttpAuthController* auth_controller,
+    net::CompletionCallback callback) {
+  // Since have not way to respond, simply invoke the callback and the
+  // request will fail.
+  callback.Run(net::OK);
+}
+
 void ProxyResolvingClientSocket::ProcessConnectDone(int status) {
   if (status != net::OK) {
     // If the connection fails, try another proxy.
     status = ReconsiderProxyAfterError(status);
     // ReconsiderProxyAfterError either returns an error (in which case it is
     // not reconsidering a proxy) or returns ERR_IO_PENDING if it is considering
     // another proxy.
     DCHECK_NE(status, net::OK);
     if (status == net::ERR_IO_PENDING)
       // Proxy reconsideration pending. Return.
@@ skipping 173 matching lines @@
   return base::TimeDelta::FromMicroseconds(-1);
 }
 
 void ProxyResolvingClientSocket::CloseTransportSocket() {
   if (transport_.get() && transport_->socket())
     transport_->socket()->Disconnect();
   transport_.reset();
 }
 
 }  // namespace notifier