Allow chrome to handle 407 auth challenges to CONNECT requests

net/http/http_stream_factory_impl_job.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_STREAM_FACTORY_IMPL_JOB_H_
 #define NET_HTTP_HTTP_STREAM_FACTORY_IMPL_JOB_H_
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "net/base/completion_callback.h"
 #include "net/base/net_log.h"
 #include "net/base/ssl_config_service.h"
 #include "net/http/http_auth.h"
 #include "net/http/http_auth_controller.h"
+#include "net/http/http_proxy_client_socket_pool.h"
 #include "net/http/http_request_info.h"
 #include "net/http/http_stream_factory_impl.h"
 #include "net/proxy/proxy_service.h"
 #include "net/socket/client_socket_handle.h"
 #include "net/socket/ssl_client_socket.h"
 
 namespace net {
 
 class ClientSocketHandle;
 class HttpAuthController;
@@ skipping 14 matching lines @@
 
   // Start initiates the process of creating a new HttpStream. |request| will be
   // notified upon completion if the Job has not been Orphan()'d.
   void Start(Request* request);
 
   // Preconnect will attempt to request |num_streams| sockets from the
   // appropriate ClientSocketPool.
   int Preconnect(int num_streams);
 
   int RestartTunnelWithProxyAuth(const AuthCredentials& credentials);
+  void ReallyRestartTunnelWithProxyAuth();

[vandebo (ex-Chrome), 2012/01/19 20:12:49]

nit: These are usually named DoFoo

[Ryan Hamilton, 2012/01/19 23:11:19]

Done.  Though I thought DoFoo was typically reserved for the methods called from
DoLoop()?  (I also moved this to private)

[vandebo (ex-Chrome), 2012/01/20 20:49:29]

In the network code, the DoLoop methods all start with Do, but more generally in
Chrome, there are On and Do methods when a level of indirection is needed

+
   LoadState GetLoadState() const;
 
   // Marks this Job as the "alternate" job, from Alternate-Protocol. Tracks the
   // original url so we can mark the Alternate-Protocol as broken if
   // we fail to connect.
   void MarkAsAlternate(const GURL& original_url);
 
   // Tells |this| to wait for |job| to resume it.
   void WaitFor(Job* job);
 
@@ skipping 56 matching lines @@
     STATE_DONE,
     STATE_NONE
   };
 
   void OnStreamReadyCallback();
   void OnSpdySessionReadyCallback();
   void OnStreamFailedCallback(int result);
   void OnCertificateErrorCallback(int result, const SSLInfo& ssl_info);
   void OnNeedsProxyAuthCallback(const HttpResponseInfo& response_info,
                                 HttpAuthController* auth_controller);
+  void OnNeedsProxyTunnelAuthCallback(const HttpResponseInfo& response_info,
+                                      HttpAuthController* auth_controller,
+                                      CompletionCallback callback);
   void OnNeedsClientAuthCallback(SSLCertRequestInfo* cert_info);
   void OnHttpsProxyTunnelResponseCallback(const HttpResponseInfo& response_info,
                                           HttpStream* stream);
   void OnPreconnectsComplete();
 
   void OnIOComplete(int result);
   int RunLoop(int result);
   int DoLoop(int result);
   int StartInternal();
 
@@ skipping 110 matching lines @@
 
   // Force spdy only for SSL connections.
   bool force_spdy_over_ssl_;
 
   // The certificate error while using SPDY over SSL for insecure URLs.
   int spdy_certificate_error_;
 
   scoped_refptr<HttpAuthController>
       auth_controllers_[HttpAuth::AUTH_NUM_TARGETS];
 
+  // Invoked after a request for tunnel auth has been handled.
+  CompletionCallback tunnel_auth_handled_callback_;
+
   // True when the tunnel is in the process of being established - we can't
   // read from the socket until the tunnel is done.
   bool establishing_tunnel_;
 
   scoped_ptr<HttpStream> stream_;
 
   // True if we negotiated NPN.
   bool was_npn_negotiated_;
 
   // Protocol negotiated with the server.
@@ skipping 16 matching lines @@
   bool existing_available_pipeline_;
 
   base::WeakPtrFactory<Job> ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(Job);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_STREAM_FACTORY_IMPL_JOB_H_