Allow chrome to handle 407 auth challenges to CONNECT requests

jingle/notifier/base/proxy_resolving_client_socket.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "jingle/notifier/base/proxy_resolving_client_socket.h"
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/compiler_specific.h"
@@ skipping 154 matching lines @@
       CloseTransportSocket();
       RunUserConnectCallback(status);
       return;
     }
   }
 
   transport_.reset(new net::ClientSocketHandle);
   // Now that we have resolved the proxy, we need to connect.
   status = net::InitSocketHandleForRawConnect(
       dest_host_port_pair_, network_session_.get(), proxy_info_, ssl_config_,
-      ssl_config_, bound_net_log_, transport_.get(), connect_callback_);
+      ssl_config_, bound_net_log_, transport_.get(), connect_callback_,
+      base::Bind(&ProxyResolvingClientSocket::OnNeedsProxyTunnelAuthCallback,
+                 base::Unretained(this)));
   if (status != net::ERR_IO_PENDING) {
     // Since this method is always called asynchronously. it is OK to call
     // ProcessConnectDone synchronously.
     ProcessConnectDone(status);
   }
 }
 
+void ProxyResolvingClientSocket::OnNeedsProxyTunnelAuthCallback(
+    const net::HttpResponseInfo& response_info,
+    net::HttpAuthController* auth_controller,
+    net::CompletionCallback callback) {
+  // TODO(rch): figure out what to do here

[cbentzel, 2012/01/18 12:14:22]

Do you want to figure this out prior to landing this CL?

[akalin, 2012/01/19 21:07:37]

so I tried to trace through what 'regular' sockets do and as far as I can tell
it ends up calling HttpNetworkTransaction::OnNeedsProxyAuth.  This client socket
is used for XMPP connections (used by sync and cloud print) and so there's no
HTTP transaction at all (I assume that HttpNetworkTransaction refers to the
'real' HTTP connection and not possibly the HTTP proxy).

So in Chrome, whenever proxy auth is needed for a web page it pops up a window
asking for credentials, right?  We've never supported that for sync
(http://crbug.com/19581), and I think doing so would require thinking through
the UI flow (since users may be confused by sync popping up an auth dialog when
there's no visible web page).

So, short answer, I think we can 'fail' here, or do whatever it used to do
before this change.

[Ryan Hamilton, 2012/01/19 23:11:19]

Done.

[Ryan Hamilton, 2012/01/19 23:11:19]

Done.

+  callback.Run(net::OK);
+}
+
 void ProxyResolvingClientSocket::ProcessConnectDone(int status) {
   if (status != net::OK) {
     // If the connection fails, try another proxy.
     status = ReconsiderProxyAfterError(status);
     // ReconsiderProxyAfterError either returns an error (in which case it is
     // not reconsidering a proxy) or returns ERR_IO_PENDING if it is considering
     // another proxy.
     DCHECK_NE(status, net::OK);
     if (status == net::ERR_IO_PENDING)
       // Proxy reconsideration pending. Return.
@@ skipping 173 matching lines @@
   return base::TimeDelta::FromMicroseconds(-1);
 }
 
 void ProxyResolvingClientSocket::CloseTransportSocket() {
   if (transport_.get() && transport_->socket())
     transport_->socket()->Disconnect();
   transport_.reset();
 }
 
 }  // namespace notifier