Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 9147056: Fix for single line file modification (Closed)

Created:
8 years, 11 months ago by M-A Ruel
Modified:
8 years, 11 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Fix for single line file modification When a file contains a single line of text, svn diff will generate an odd hunk header. Modify the hunk parsing code to accept this format. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117143

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -6 lines) Patch
M patch.py View 1 chunk +11 lines, -6 lines 0 comments Download
M testing_support/patches_data.py View 1 chunk +11 lines, -0 lines 0 comments Download
M tests/patch_test.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
8 years, 11 months ago (2012-01-11 01:30:09 UTC) #1
Dirk Pranke
lgtm
8 years, 11 months ago (2012-01-11 01:36:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/9147056/1
8 years, 11 months ago (2012-01-11 01:45:01 UTC) #3
commit-bot: I haz the power
8 years, 11 months ago (2012-01-11 01:51:31 UTC) #4
Change committed as 117143

Powered by Google App Engine
This is Rietveld 408576698