Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 9147054: Revert 117136 - separate about page into its own page (included in chrome://chrome) (Closed)

Created:
8 years, 11 months ago by Dan Beam
Modified:
8 years, 11 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, Aaron Boodman, arv (Not doing code reviews), mihaip+watch_chromium.org
Visibility:
Public.

Description

Revert 117136 - separate about page into its own page (included in chrome://chrome) for now it's only enabled in cros, but we plan to have a version for desktop chrome as well, which is why I took it out of the chromeos namespace. BUG=109203 TEST=manual Review URL: http://codereview.chromium.org/9124028 TBR=estade@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117139

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1047 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/resources/about_page/about_page.css View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/resources/about_page/about_page.html View 1 chunk +0 lines, -145 lines 0 comments Download
D chrome/browser/resources/about_page/about_page.js View 1 chunk +0 lines, -227 lines 0 comments Download
M chrome/browser/resources/extensions/extensions.html View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/resources/extensions/extensions.js View 2 chunks +3 lines, -2 lines 0 comments Download
A + chrome/browser/resources/options2/about_page.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/options2/about_page.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/options2/about_page.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/options2/options.html View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/options2/options.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/options2/options_bundle.js View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/uber/uber.css View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/uber/uber.html View 2 chunks +1 line, -9 lines 0 comments Download
D chrome/browser/ui/webui/about_page/about_page_handler.h View 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/browser/ui/webui/about_page/about_page_handler.cc View 1 chunk +0 lines, -469 lines 0 comments Download
D chrome/browser/ui/webui/about_page/about_page_ui.h View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/browser/ui/webui/about_page/about_page_ui.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_factory.cc View 2 chunks +0 lines, -3 lines 0 comments Download
A + chrome/browser/ui/webui/options2/chromeos/about_page_handler2.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/webui/options2/chromeos/about_page_handler2.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/ui/webui/options2/options_ui2.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/uber/uber_ui.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/chrome_browser.gypi View 3 chunks +2 lines, -8 lines 0 comments Download
M chrome/common/url_constants.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/url_constants.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Dan Beam
8 years, 11 months ago (2012-01-11 01:26:30 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698